Don't throw exception when refreshing fields of an indexpattern #55836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Condition: Indexpattern without indices and a refresh of fields is triggered - this caused an empty discover screen - and you couldn't remove the index pattern in management
kertal
added
Feature:Discover
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
commented
Jan 24, 2020
Comment on lines
156
to
165
| try { | ||
| if (forceFieldRefresh || this.isFieldRefreshRequired()) { | ||
| await this.refreshFields(); | ||
| } | ||
| } catch (e) { | ||
| // eslint-disable-next-line no-console | ||
| console.error(`Refreshing fields of index pattern ${this.id} failed`, { | ||
| forceFieldRefresh, | ||
| fields: this.fields, | ||
| }); |
There was a problem hiding this comment.
So this is the mystery, normally, in Discover, forceFieldRefresh is false, and also this.isFieldRefreshRequired should return false. Currently I just could reproduce it with setting forceFieldRefresh manually to true. So the UI in Discover and Management works again. The question is, what causes the this.isFieldRefreshRequired to be true?
@LeeDr we should take a look at the saved object of the index pattern that causes this failure. maybe there are no fields stored? there must be something wrong with it .
lizozom
reviewed
Jan 26, 2020
src/plugins/data/public/index_patterns/index_patterns/index_pattern.ts
Outdated
Show resolved
Hide resolved
…-24-catch-refresh-field-exception
lizozom
approved these changes
Jan 27, 2020
kertal
changed the title
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jan 27, 2020
…tic#55836) * An exception when refreshing fields of an selected index pattern causes Discover to load incompletely * Add index ID + Title to the error message for
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jan 27, 2020
…tic#55836) * An exception when refreshing fields of an selected index pattern causes Discover to load incompletely * Add index ID + Title to the error message for
kertal
added a commit
that referenced
this pull request
Jan 27, 2020
…) (#56031) * An exception when refreshing fields of an selected index pattern caused Discover to load incompletely * Add index ID + Title of the index pattern to the error messages in this case
kertal
added a commit
that referenced
this pull request
Jan 28, 2020
…) (#56066) * An exception when refreshing fields of an selected index pattern caused Discover to load incompletely * Remove throw Exception code * Add index ID + Title to the error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When there are no indices available for the default index pattern, and its saved object contains no fields, Kibana starts an operation to refresh the field information. This fails and causes an exception when loading Discover not showing any UI except the error message.
This PR fixes this error, and improves the error message to provide more information which index pattern caused the error.
Furthermore you can delete this index pattern, which was also not possible before.
Reproduce the issue:
Use a new Kibana instance without any index pattern, create an index pattern with the Saved Object API e.g.
This index pattern is now the default index pattern. Since there are no fields in the saved object, when you load Discover, this causes an automatic refresh of the index pattern trying to get field information of existing indices. This will fail, and cause the following error screen in Discover:
Fixes: #54982, Fixes #53878
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately