Skip to content

Commit

Permalink
Don't throw exception when refreshing fields of an indexpattern (#55836
Browse files Browse the repository at this point in the history
…) (#56066)

* An exception when refreshing fields of an selected index pattern caused Discover to load incompletely
* Remove throw Exception code
* Add index ID + Title to the error message
  • Loading branch information
kertal authored Jan 28, 2020
1 parent e992c40 commit 285c3ac
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -581,10 +581,13 @@ export class IndexPattern implements IIndexPattern {

toasts.addError(err, {
title: i18n.translate('data.indexPatterns.fetchFieldErrorTitle', {
defaultMessage: 'Error fetching fields',
defaultMessage: 'Error fetching fields for index pattern {title} (ID: {id})',
values: {
id: this.id,
title: this.title,
},
}),
});
throw err;
});
}

Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,6 @@
"data.functions.esaggs.inspector.dataRequest.description": "このリクエストは Elasticsearch にクエリし、ビジュアライゼーション用のデータを取得します。",
"data.functions.esaggs.inspector.dataRequest.title": "データ",
"data.indexPatterns.editIndexPattern": "インデックスパターンを編集",
"data.indexPatterns.fetchFieldErrorTitle": "フィールドの取得中にエラーが発生",
"data.indexPatterns.unableWriteLabel": "インデックスパターンを書き込めません!このインデックスパターンへの最新の変更を取得するには、ページを更新してください。",
"data.indexPatterns.unknownFieldErrorMessage": "インデックスパターン「{title}」のフィールド「{name}」が不明なフィールドタイプを使用しています。",
"data.indexPatterns.unknownFieldHeader": "不明なフィールドタイプ {type}",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,6 @@
"data.functions.esaggs.inspector.dataRequest.description": "此请求将查询 Elasticsearch 以获取用于可视化的数据。",
"data.functions.esaggs.inspector.dataRequest.title": "数据",
"data.indexPatterns.editIndexPattern": "编辑索引模式",
"data.indexPatterns.fetchFieldErrorTitle": "提取字段时出错",
"data.indexPatterns.unableWriteLabel": "无法写入索引模式!请刷新页面以获取此索引模式的最新更改。",
"data.indexPatterns.unknownFieldErrorMessage": "indexPattern “{title}” 中的字段 “{name}” 使用未知字段类型。",
"data.indexPatterns.unknownFieldHeader": "未知字段类型 {type}",
Expand Down

0 comments on commit 285c3ac

Please sign in to comment.