Improve solution by refactoring refreshFields

elastic · Jan 27, 2020 · 659df28 · 659df28
1 parent 57db24a
commit 659df28
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/src/plugins/data/public/index_patterns/index_patterns/index_pattern.ts b/src/plugins/data/public/index_patterns/index_patterns/index_pattern.ts
@@ -153,17 +153,11 @@ export class IndexPattern implements IIndexPattern {
     if (!this.id) {
       return;
     }
-    try {
-      if (forceFieldRefresh || this.isFieldRefreshRequired()) {
-        await this.refreshFields();
-      }
-    } catch (e) {
-      // eslint-disable-next-line no-console
-      console.error(`Refreshing fields of index pattern ${this.id} failed`, {
-        forceFieldRefresh,
-        fields: this.fields,
-      });
+
+    if (forceFieldRefresh || this.isFieldRefreshRequired()) {
+      await this.refreshFields();
     }
+
     this.initFields();
   }
 
@@ -498,10 +492,13 @@ export class IndexPattern implements IIndexPattern {
 
         toasts.addError(err, {
           title: i18n.translate('data.indexPatterns.fetchFieldErrorTitle', {
-            defaultMessage: 'Error fetching fields',
+            defaultMessage: `Error fetching fields for index pattern {title} (ID: {id})`,
+            values: {
+              id: this.id,
+              title: this.title,
+            },
           }),
         });
-        throw err;
       });
   }