Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw exception when refreshing fields of an indexpattern #55836

Merged
merged 4 commits into from
Jan 27, 2020
Merged

Don't throw exception when refreshing fields of an indexpattern #55836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57db24a
Catch exception when refreshing fields of an indexpattern
kertal Jan 24, 2020
659df28
Improve solution by refactoring refreshFields
kertal Jan 27, 2020
303d613
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-01…
kertal Jan 27, 2020
dcd0ff9
Fix i18n
kertal Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/plugins/data/public/index_patterns/index_patterns/index_pattern.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,10 +492,13 @@ export class IndexPattern implements IIndexPattern {

toasts.addError(err, {
title: i18n.translate('data.indexPatterns.fetchFieldErrorTitle', {
defaultMessage: 'Error fetching fields',
defaultMessage: 'Error fetching fields for index pattern {title} (ID: {id})',
values: {
id: this.id,
title: this.title,
},
}),
});
throw err;
});
}

Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,6 @@
"data.filter.options.pinAllFiltersButtonLabel": "すべてピン付け",
"data.filter.options.unpinAllFiltersButtonLabel": "すべてのピンを外す",
"data.filter.searchBar.changeAllFiltersTitle": "すべてのフィルターの変更",
"data.indexPatterns.fetchFieldErrorTitle": "フィールドの取得中にエラーが発生",
"data.indexPatterns.unableWriteLabel": "インデックスパターンを書き込めません！このインデックスパターンへの最新の変更を取得するには、ページを更新してください。",
"data.indexPatterns.unknownFieldErrorMessage": "インデックスパターン「{title}」のフィールド「{name}」が不明なフィールドタイプを使用しています。",
"data.indexPatterns.unknownFieldHeader": "不明なフィールドタイプ {type}",
Expand Down Expand Up @@ -13205,4 +13204,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "フィールドを選択してください。",
"xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。"
}
}
}
3 changes: 1 addition & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,6 @@
"data.filter.options.pinAllFiltersButtonLabel": "全部固定",
"data.filter.options.unpinAllFiltersButtonLabel": "全部取消固定",
"data.filter.searchBar.changeAllFiltersTitle": "更改所有筛选",
"data.indexPatterns.fetchFieldErrorTitle": "提取字段时出错",
"data.indexPatterns.unableWriteLabel": "无法写入索引模式！请刷新页面以获取此索引模式的最新更改。",
"data.indexPatterns.unknownFieldErrorMessage": "indexPattern “{title}” 中的字段 “{name}” 使用未知字段类型。",
"data.indexPatterns.unknownFieldHeader": "未知字段类型 {type}",
Expand Down Expand Up @@ -13204,4 +13203,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "此字段必填。",
"xpack.watcher.watcherDescription": "通过创建、管理和监测警报来检测数据中的更改。"
}
}
}