[Cloud Security] Refactoring cloud-security-posture packages' folder structure #196008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfirpeled
added
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
|
|
@kfirpeled context behind the change? |
maxcold
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
@animehart fyi
@kfirpeled can you update README on the kbn-cloud-security-package to mention which packages we have and for what usecase
Sure, sorry for the lack of context and thanks for checking it out. @opauloh suggested to restructure our folders to a more intuitive way. Here his original comment #195307 (comment) I do agree that if we gonna have multiple packages available, and not only public/common. It would make it easier to restructure the folders and packages as Paulo suggested. You can take an example how apm team structured their packages, it looks quite convenient |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11329861798 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11329861798 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kfirpeled
added a commit
to kfirpeled/kibana
that referenced
this pull request
Oct 15, 2024
…structure (elastic#196008) ## Summary Organized the team's packages under the same root folder ``` "@kbn/cloud-security-posture": "link:x-pack/packages/cloud_security_posture/public", "@kbn/cloud-security-posture-common": "link:x-pack/packages/kbn-cloud-security-posture/common", "@kbn/cloud-security-posture-graph": "link:x-pack/packages/kbn-cloud-security-posture/graph", ``` --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 96eff23) # Conflicts: # .github/CODEOWNERS
kfirpeled
added a commit
that referenced
this pull request
Oct 15, 2024
…older structure (#196008) (#196267) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Refactoring cloud-security-posture packages' folder structure (#196008)](#196008) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kfir Peled","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T14:43:08Z","message":"[Cloud Security] Refactoring cloud-security-posture packages' folder structure (#196008)\n\n## Summary\r\n\r\nOrganized the team's packages under the same root folder\r\n\r\n```\r\n \"@kbn/cloud-security-posture\": \"link:x-pack/packages/cloud_security_posture/public\",\r\n \"@kbn/cloud-security-posture-common\": \"link:x-pack/packages/kbn-cloud-security-posture/common\",\r\n \"@kbn/cloud-security-posture-graph\": \"link:x-pack/packages/kbn-cloud-security-posture/graph\",\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"96eff23f50f68a161b85d6d05309fa3ea6a287b4","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"number":196008,"url":"https://github.com/elastic/kibana/pull/196008","mergeCommit":{"message":"[Cloud Security] Refactoring cloud-security-posture packages' folder structure (#196008)\n\n## Summary\r\n\r\nOrganized the team's packages under the same root folder\r\n\r\n```\r\n \"@kbn/cloud-security-posture\": \"link:x-pack/packages/cloud_security_posture/public\",\r\n \"@kbn/cloud-security-posture-common\": \"link:x-pack/packages/kbn-cloud-security-posture/common\",\r\n \"@kbn/cloud-security-posture-graph\": \"link:x-pack/packages/kbn-cloud-security-posture/graph\",\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"96eff23f50f68a161b85d6d05309fa3ea6a287b4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196008","number":196008,"mergeCommit":{"message":"[Cloud Security] Refactoring cloud-security-posture packages' folder structure (#196008)\n\n## Summary\r\n\r\nOrganized the team's packages under the same root folder\r\n\r\n```\r\n \"@kbn/cloud-security-posture\": \"link:x-pack/packages/cloud_security_posture/public\",\r\n \"@kbn/cloud-security-posture-common\": \"link:x-pack/packages/kbn-cloud-security-posture/common\",\r\n \"@kbn/cloud-security-posture-graph\": \"link:x-pack/packages/kbn-cloud-security-posture/graph\",\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"96eff23f50f68a161b85d6d05309fa3ea6a287b4"}}]}] BACKPORT-->
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Organized the team's packages under the same root folder