[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails #195889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiriamAparicio
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
MiriamAparicio
added
backport:skip
botelastic
bot
added
the
ci:project-deploy-observability
cauemarcondes
approved these changes
Oct 11, 2024
packages/kbn-apm-synthtrace/src/lib/apm/client/apm_synthtrace_kibana_client.ts
Outdated
Show resolved
Hide resolved
packages/kbn-apm-synthtrace/src/lib/apm/client/apm_synthtrace_kibana_client.ts
Outdated
Show resolved
Hide resolved
packages/kbn-apm-synthtrace/src/lib/apm/client/apm_synthtrace_kibana_client.ts
Outdated
Show resolved
Hide resolved
packages/kbn-apm-synthtrace/src/lib/apm/client/apm_synthtrace_kibana_client.ts
Outdated
Show resolved
Hide resolved
MiriamAparicio
force-pushed
the
195436-fallback-fetch-apm-package
branch
from
4c8651d to
808ce7c
Compare
Comment on lines
58
to
67
| // First attempt fetch latest Prerelease version (prerelease=true) | ||
| return await fetchPackageVersion({ prerelease: true }); | ||
| } catch (error) { | ||
| this.logger.debug( | ||
| 'Fetching latestes prerelease version failed, retrying with latest GA version' | ||
| ); | ||
| // Retry with fetch latest GA version (prerelease=false) | ||
| const retryResult = await fetchPackageVersion({ prerelease: false }).catch((retryError) => { | ||
| throw retryError; | ||
| }); |
There was a problem hiding this comment.
I think you can drop the comments here too. The code is pretty obvious.
Also, do you still need to add the catch block on the retry?
There was a problem hiding this comment.
I added to avoid having an unhandled promise rejection. Do you think it's not necessary?
I look where we call fetchLatestApmPackageVersion() and I'm not sure that it will be handled there
There was a problem hiding this comment.
Can you try it out by juts throwing a new error when prerelease: false and remove the catch to see what will happen?
crespocarlos
approved these changes
Oct 14, 2024
⏳ Build in-progress
History
|
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Nov 27, 2024
…rerelease fetch fails (elastic#195889) Closes elastic#195436 (cherry picked from commit ce2cf6b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Nov 27, 2024
…rerelease fetch fails (elastic#195889) Closes elastic#195436 (cherry picked from commit ce2cf6b)
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Nov 27, 2024
…rerelease fetch fails (elastic#195889) Closes elastic#195436 (cherry picked from commit ce2cf6b)
crespocarlos
added a commit
that referenced
this pull request
Nov 27, 2024
…atest prerelease fetch fails (#195889) (#201928) closes #201513 closes [#201512](#201512) # Backport This will backport the following commits from `main` to `8.17`: - [[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)](#195889) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Miriam","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T14:06:33Z","message":"[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)\n\nCloses https://github.com/elastic/kibana/issues/195436","sha":"ce2cf6bb3c7fb36ed7a3d5bf23960994f0b17b50","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"number":195889,"url":"https://github.com/elastic/kibana/pull/195889","mergeCommit":{"message":"[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)\n\nCloses https://github.com/elastic/kibana/issues/195436","sha":"ce2cf6bb3c7fb36ed7a3d5bf23960994f0b17b50"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195889","number":195889,"mergeCommit":{"message":"[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)\n\nCloses https://github.com/elastic/kibana/issues/195436","sha":"ce2cf6bb3c7fb36ed7a3d5bf23960994f0b17b50"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Miriam <[email protected]>
crespocarlos
added a commit
that referenced
this pull request
Nov 27, 2024
…test prerelease fetch fails (#195889) (#201926) # Backport This will backport the following commits from `main` to `8.x`: - [[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)](#195889) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Miriam","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T14:06:33Z","message":"[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)\n\nCloses https://github.com/elastic/kibana/issues/195436","sha":"ce2cf6bb3c7fb36ed7a3d5bf23960994f0b17b50","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"number":195889,"url":"https://github.com/elastic/kibana/pull/195889","mergeCommit":{"message":"[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)\n\nCloses https://github.com/elastic/kibana/issues/195436","sha":"ce2cf6bb3c7fb36ed7a3d5bf23960994f0b17b50"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195889","number":195889,"mergeCommit":{"message":"[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)\n\nCloses https://github.com/elastic/kibana/issues/195436","sha":"ce2cf6bb3c7fb36ed7a3d5bf23960994f0b17b50"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Miriam <[email protected]>
crespocarlos
added a commit
that referenced
this pull request
Nov 27, 2024
…atest prerelease fetch fails (#195889) (#201929) # Backport This will backport the following commits from `main` to `8.16`: - [[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)](#195889) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Miriam","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T14:06:33Z","message":"[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)\n\nCloses https://github.com/elastic/kibana/issues/195436","sha":"ce2cf6bb3c7fb36ed7a3d5bf23960994f0b17b50","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"number":195889,"url":"https://github.com/elastic/kibana/pull/195889","mergeCommit":{"message":"[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)\n\nCloses https://github.com/elastic/kibana/issues/195436","sha":"ce2cf6bb3c7fb36ed7a3d5bf23960994f0b17b50"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195889","number":195889,"mergeCommit":{"message":"[ObsUX][Synthtrace] Fallback to latest GA package version if latest prerelease fetch fails (#195889)\n\nCloses https://github.com/elastic/kibana/issues/195436","sha":"ce2cf6bb3c7fb36ed7a3d5bf23960994f0b17b50"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Miriam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195436