Execution type field #195884
Merged
Execution type field #195884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
nkhristinin
added
release_note:skip
marshallmain
approved these changes
Oct 11, 2024
| @@ -50,6 +51,7 @@ export const wrapSuppressedNewTermsAlerts = ({ | |||
| publicBaseUrl: string | undefined; | |||
| primaryTimestamp: string; | |||
| secondaryTimestamp?: string; | |||
| intendedTimestamp?: Date; | |||
There was a problem hiding this comment.
Suggested change
| intendedTimestamp?: Date; | |
| intendedTimestamp: Date | undefined; |
| @@ -52,6 +53,7 @@ export const wrapSuppressedEsqlAlerts = ({ | |||
| }; | |||
| primaryTimestamp: string; | |||
| secondaryTimestamp?: string; | |||
| intendedTimestamp?: Date; | |||
There was a problem hiding this comment.
Suggested change
| intendedTimestamp?: Date; | |
| intendedTimestamp: Date | undefined; |
| @@ -47,7 +47,8 @@ export const buildAlertGroupFromSequence = ( | |||
| buildReasonMessage: BuildReasonMessage, | |||
| indicesToQuery: string[], | |||
| alertTimestampOverride: Date | undefined, | |||
| publicBaseUrl?: string | |||
| publicBaseUrl?: string, | |||
| intendedTimestamp?: Date | |||
There was a problem hiding this comment.
Suggested change
| intendedTimestamp?: Date | |
| intendedTimestamp: Date | undefined |
There was a problem hiding this comment.
Fixed, other places, but here we will have error:
A required parameter cannot follow an optional parameter
Because parameters here is not an object
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11329624950 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
## Added new field - execution type for alerts Added new field only for security type alerts: `kibana.alert.rule.execution.type` - can be `manual` or `scheduled` Also, move intended timestamp settings from `create_persistence_rule_type_wrapper` to `build_alert` Also added those new field to Alert schema and types. https://github.com/user-attachments/assets/c5b021a6-4763-47ae-b46c-814a138be65a For tests: - tests all rule types with and without suppression: `kibana.alert.rule.execution.type` - should be `scheduled`, `kibana.alert.intended_timestamp` - should equal alert timestamp - tests all rules with and without suppression with manual run - `kibana.alert.rule.execution.type` - should be `manual`, `kibana.alert.intended_timestamp` - should equal date inside you manual rule run date range --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 3d466a7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Execution type field (#195884)](#195884) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Khristinin Nikita","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T14:29:12Z","message":"Execution type field (#195884)\n\n## Added new field - execution type for alerts\r\n\r\nAdded new field only for security type alerts:\r\n\r\n`kibana.alert.rule.execution.type` - can be `manual` or `scheduled`\r\n\r\nAlso, move intended timestamp settings from\r\n`create_persistence_rule_type_wrapper` to `build_alert`\r\n\r\nAlso added those new field to Alert schema and types.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/c5b021a6-4763-47ae-b46c-814a138be65a\r\n\r\n\r\n\r\nFor tests:\r\n\r\n- tests all rule types with and without suppression:\r\n`kibana.alert.rule.execution.type` - should be `scheduled`,\r\n`kibana.alert.intended_timestamp` - should equal alert timestamp\r\n\r\n- tests all rules with and without suppression with manual run -\r\n`kibana.alert.rule.execution.type` - should be `manual`,\r\n`kibana.alert.intended_timestamp` - should equal date inside you manual\r\nrule run date range\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3d466a72a8ab181aadf562ab6c27a5affa32dc96","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"Execution type field","number":195884,"url":"https://github.com/elastic/kibana/pull/195884","mergeCommit":{"message":"Execution type field (#195884)\n\n## Added new field - execution type for alerts\r\n\r\nAdded new field only for security type alerts:\r\n\r\n`kibana.alert.rule.execution.type` - can be `manual` or `scheduled`\r\n\r\nAlso, move intended timestamp settings from\r\n`create_persistence_rule_type_wrapper` to `build_alert`\r\n\r\nAlso added those new field to Alert schema and types.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/c5b021a6-4763-47ae-b46c-814a138be65a\r\n\r\n\r\n\r\nFor tests:\r\n\r\n- tests all rule types with and without suppression:\r\n`kibana.alert.rule.execution.type` - should be `scheduled`,\r\n`kibana.alert.intended_timestamp` - should equal alert timestamp\r\n\r\n- tests all rules with and without suppression with manual run -\r\n`kibana.alert.rule.execution.type` - should be `manual`,\r\n`kibana.alert.intended_timestamp` - should equal date inside you manual\r\nrule run date range\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3d466a72a8ab181aadf562ab6c27a5affa32dc96"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195884","number":195884,"mergeCommit":{"message":"Execution type field (#195884)\n\n## Added new field - execution type for alerts\r\n\r\nAdded new field only for security type alerts:\r\n\r\n`kibana.alert.rule.execution.type` - can be `manual` or `scheduled`\r\n\r\nAlso, move intended timestamp settings from\r\n`create_persistence_rule_type_wrapper` to `build_alert`\r\n\r\nAlso added those new field to Alert schema and types.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/c5b021a6-4763-47ae-b46c-814a138be65a\r\n\r\n\r\n\r\nFor tests:\r\n\r\n- tests all rule types with and without suppression:\r\n`kibana.alert.rule.execution.type` - should be `scheduled`,\r\n`kibana.alert.intended_timestamp` - should equal alert timestamp\r\n\r\n- tests all rules with and without suppression with manual run -\r\n`kibana.alert.rule.execution.type` - should be `manual`,\r\n`kibana.alert.intended_timestamp` - should equal date inside you manual\r\nrule run date range\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3d466a72a8ab181aadf562ab6c27a5affa32dc96"}}]}] BACKPORT--> Co-authored-by: Khristinin Nikita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new field - execution type for alerts
Added new field only for security type alerts:
kibana.alert.rule.execution.type- can bemanualorscheduledAlso, move intended timestamp settings from
create_persistence_rule_type_wrappertobuild_alertAlso added those new field to Alert schema and types.
Screen.Recording.2024-10-11.at.16.12.08.mov
For tests:
tests all rule types with and without suppression:
kibana.alert.rule.execution.type- should bescheduled,kibana.alert.intended_timestamp- should equal alert timestamptests all rules with and without suppression with manual run -
kibana.alert.rule.execution.type- should bemanual,kibana.alert.intended_timestamp- should equal date inside you manual rule run date range