[ECO][Infra] Add callout for ingesting metrics data in Host and Container views #195378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers-to-ingest-metrics-data
…ers-to-ingest-metrics-data
Good point. It's better to hide if the array doesn't contain |
tonyghiani
approved these changes
Oct 11, 2024
...gins/observability_solution/infra/public/components/asset_details/tabs/overview/overview.tsx
Outdated
Show resolved
Hide resolved
...gins/observability_solution/infra/public/components/asset_details/tabs/overview/overview.tsx
Show resolved
Hide resolved
x-pack/plugins/observability_solution/infra/public/components/asset_details/template/page.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| import { EntityDataStreamType } from '@kbn/observability-shared-plugin/common'; | ||
|
|
||
| export function isMetricsSignal(dataStreamTypes: EntityDataStreamType[] = []) { |
There was a problem hiding this comment.
Do you think naming it hasMetricsSignal would make more sense?
There was a problem hiding this comment.
I updated it from hasMetrics to isMetricsSignal based on this comment in the PR.
...gins/observability_solution/infra/public/components/asset_details/tabs/overview/overview.tsx
Show resolved
Hide resolved
…st-metrics-data' of https://github.com/iblancof/kibana into 193703-infra-eco-show-a-callout-to-prompt-users-to-ingest-metrics-data
…ers-to-ingest-metrics-data
cauemarcondes
approved these changes
Oct 14, 2024
...bservability_solution/infra/public/components/asset_details/add_metrics_callout/constants.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
Total ESLint disabled count
History
cc @iblancof |
iblancof
deleted the
193703-infra-eco-show-a-callout-to-prompt-users-to-ingest-metrics-data
branch
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11329854789 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
…iner views (elastic#195378) ## Summary Closes elastic#193703 This PR introduces a callout designed to prompt users to ingest metrics data in the Host and Container views. The callout will be displayed on the following tabs: - **Hosts**: Overview, Metrics, Processes - **Containers**: Overview, Metrics The primary condition for showing the callout is that the asset does not currently have any metrics data available. This enhancement aims to encourage users to take action and improve their monitoring experience. Additional details include: - The callout will be positioned below the date picker for better visibility. - Links for "Add Metrics" will guide users to the appropriate onboarding pages based on their asset type. - The callout will be dismissible on the Overview tab, and the KPI section will be hidden in favor of the callout for a cleaner interface. - Custom telemetry events will be tracked to measure user interactions with the callout. - Only Docker and K8 containers will show the callout. **Host** |Tab|| |-|-| |Overview|| |Metrics|| |Processes|| **Container** |Tab|| |-|-| |Overview|| |Metrics|| --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Caue Marcondes <[email protected]> (cherry picked from commit 96966c5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
… Container views (#195378) (#196158) # Backport This will backport the following commits from `main` to `8.x`: - [[ECO][Infra] Add callout for ingesting metrics data in Host and Container views (#195378)](#195378) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T14:42:44Z","message":"[ECO][Infra] Add callout for ingesting metrics data in Host and Container views (#195378)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/193703\r\n\r\nThis PR introduces a callout designed to prompt users to ingest metrics\r\ndata in the Host and Container views.\r\nThe callout will be displayed on the following tabs:\r\n\r\n- **Hosts**: Overview, Metrics, Processes\r\n- **Containers**: Overview, Metrics\r\n\r\nThe primary condition for showing the callout is that the asset does not\r\ncurrently have any metrics data available. This enhancement aims to\r\nencourage users to take action and improve their monitoring experience.\r\n\r\nAdditional details include:\r\n\r\n- The callout will be positioned below the date picker for better\r\nvisibility.\r\n- Links for \"Add Metrics\" will guide users to the appropriate onboarding\r\npages based on their asset type.\r\n- The callout will be dismissible on the Overview tab, and the KPI\r\nsection will be hidden in favor of the callout for a cleaner interface.\r\n- Custom telemetry events will be tracked to measure user interactions\r\nwith the callout.\r\n- Only Docker and K8 containers will show the callout.\r\n\r\n**Host**\r\n|Tab||\r\n|-|-|\r\n|Overview||\r\n|Metrics||\r\n|Processes||\r\n\r\n**Container**\r\n|Tab||\r\n|-|-|\r\n|Overview||\r\n|Metrics||\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Caue Marcondes <[email protected]>","sha":"96966c5113678b8840c7a311e7e4ed1e977b4dac","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Team:obs-ux-infra_services","v8.16.0"],"title":"[ECO][Infra] Add callout for ingesting metrics data in Host and Container views","number":195378,"url":"https://github.com/elastic/kibana/pull/195378","mergeCommit":{"message":"[ECO][Infra] Add callout for ingesting metrics data in Host and Container views (#195378)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/193703\r\n\r\nThis PR introduces a callout designed to prompt users to ingest metrics\r\ndata in the Host and Container views.\r\nThe callout will be displayed on the following tabs:\r\n\r\n- **Hosts**: Overview, Metrics, Processes\r\n- **Containers**: Overview, Metrics\r\n\r\nThe primary condition for showing the callout is that the asset does not\r\ncurrently have any metrics data available. This enhancement aims to\r\nencourage users to take action and improve their monitoring experience.\r\n\r\nAdditional details include:\r\n\r\n- The callout will be positioned below the date picker for better\r\nvisibility.\r\n- Links for \"Add Metrics\" will guide users to the appropriate onboarding\r\npages based on their asset type.\r\n- The callout will be dismissible on the Overview tab, and the KPI\r\nsection will be hidden in favor of the callout for a cleaner interface.\r\n- Custom telemetry events will be tracked to measure user interactions\r\nwith the callout.\r\n- Only Docker and K8 containers will show the callout.\r\n\r\n**Host**\r\n|Tab||\r\n|-|-|\r\n|Overview||\r\n|Metrics||\r\n|Processes||\r\n\r\n**Container**\r\n|Tab||\r\n|-|-|\r\n|Overview||\r\n|Metrics||\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Caue Marcondes <[email protected]>","sha":"96966c5113678b8840c7a311e7e4ed1e977b4dac"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195378","number":195378,"mergeCommit":{"message":"[ECO][Infra] Add callout for ingesting metrics data in Host and Container views (#195378)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/193703\r\n\r\nThis PR introduces a callout designed to prompt users to ingest metrics\r\ndata in the Host and Container views.\r\nThe callout will be displayed on the following tabs:\r\n\r\n- **Hosts**: Overview, Metrics, Processes\r\n- **Containers**: Overview, Metrics\r\n\r\nThe primary condition for showing the callout is that the asset does not\r\ncurrently have any metrics data available. This enhancement aims to\r\nencourage users to take action and improve their monitoring experience.\r\n\r\nAdditional details include:\r\n\r\n- The callout will be positioned below the date picker for better\r\nvisibility.\r\n- Links for \"Add Metrics\" will guide users to the appropriate onboarding\r\npages based on their asset type.\r\n- The callout will be dismissible on the Overview tab, and the KPI\r\nsection will be hidden in favor of the callout for a cleaner interface.\r\n- Custom telemetry events will be tracked to measure user interactions\r\nwith the callout.\r\n- Only Docker and K8 containers will show the callout.\r\n\r\n**Host**\r\n|Tab||\r\n|-|-|\r\n|Overview||\r\n|Metrics||\r\n|Processes||\r\n\r\n**Container**\r\n|Tab||\r\n|-|-|\r\n|Overview||\r\n|Metrics||\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Caue Marcondes <[email protected]>","sha":"96966c5113678b8840c7a311e7e4ed1e977b4dac"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #193703
This PR introduces a callout designed to prompt users to ingest metrics data in the Host and Container views.
The callout will be displayed on the following tabs:
The primary condition for showing the callout is that the asset does not currently have any metrics data available. This enhancement aims to encourage users to take action and improve their monitoring experience.
Additional details include:
Host
Container