[Ops] Re-enable typecheck #167392
Merged
[Ops] Re-enable typecheck #167392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
chore
Team:Operations
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-operations (Team:Operations) |
delanni
changed the title
Ikuni17
approved these changes
Sep 28, 2023
delanni
added a commit
to delanni/kibana
that referenced
this pull request
Sep 29, 2023
…c#167392) ## Summary This is hopefully the last batch of typescript issues to be fixed, related to elastic#166813. It's also re-enabling full typecheck, with this, we should be back in a clean, typechecked main branch. Blocked by elastic#167428 --------- Co-authored-by: Brad White <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: Thomas Watson <[email protected]> Co-authored-by: Patryk Kopyciński <[email protected]> Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 8a29a5e) # Conflicts: # .buildkite/pipelines/pull_request/base.yml # .buildkite/scripts/steps/check_types_commits.sh
delanni
added a commit
that referenced
this pull request
Oct 2, 2023
## Summary Semi-manual backport of #167392 This would re-enable full typecheck in the 8.10 branch. Closes: #167373 Co-authored-by: Thomas Watson <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Ikuni17
added a commit
that referenced
this pull request
Oct 2, 2023
## Summary This was missed as part of #167392
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 2, 2023
## Summary This was missed as part of elastic#167392 (cherry picked from commit f6d505a)
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [Reenable type check in api docs build (#167839)](#167839) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Brad White","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-02T23:18:13Z","message":"Reenable type check in api docs build (#167839)\n\n## Summary\r\n\r\nThis was missed as part of #167392","sha":"f6d505ab5014f7bb757480b86ab2ab3d5fe05d6c","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.11.0"],"number":167839,"url":"https://github.com/elastic/kibana/pull/167839","mergeCommit":{"message":"Reenable type check in api docs build (#167839)\n\n## Summary\r\n\r\nThis was missed as part of #167392","sha":"f6d505ab5014f7bb757480b86ab2ab3d5fe05d6c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167839","number":167839,"mergeCommit":{"message":"Reenable type check in api docs build (#167839)\n\n## Summary\r\n\r\nThis was missed as part of #167392","sha":"f6d505ab5014f7bb757480b86ab2ab3d5fe05d6c"}}]}] BACKPORT--> Co-authored-by: Brad White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were running on a partial, changed-file based typecheck until now, to get many of the typescript issues fixed. Now that we're clean, we can re-enable the previous version, full typecheck as a pre-requisite for a PR.
It's also re-enabling full typecheck, with this, we should be back in a clean, typechecked main branch.
Blocked by #167428