Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[asset manager] use metrics data plugin #166756

Merged
merged 11 commits into from
Sep 27, 2023
Merged

[asset manager] use metrics data plugin #166756

merged 11 commits into from
Sep 27, 2023

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Sep 19, 2023 •
edited
Loading

Summary

Closes #166636

  • use metrics_data_access plugin to dynamically retrieve indices where needed
  • add basic /assets/hosts api test

@klacabane klacabane self-assigned this Sep 19, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@klacabane klacabane added Team:Observed Asset Management Label used for engineers working on various parts of observed asset management Feature:Asset Manager labels Sep 19, 2023
@klacabane klacabane marked this pull request as ready for review September 20, 2023 10:43
@klacabane klacabane requested a review from a team as a code owner September 20, 2023 10:43
@klacabane klacabane added release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@klacabane klacabane mentioned this pull request Sep 27, 2023
Merged
4 tasks
jasonrhodes
jasonrhodes approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jasonrhodes jasonrhodes self-requested a review September 27, 2023 17:45
jasonrhodes
jasonrhodes approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again

@jasonrhodes jasonrhodes enabled auto-merge (squash) September 27, 2023 18:43
@jasonrhodes
Copy link
Member

This PR will likely be blocked until the TS fix one merges: #167392

@Ikuni17
Copy link
Contributor

Ikuni17 commented Sep 27, 2023

This PR will likely be blocked until the TS fix one merges: #167392

I merged main because the error in Check Types Commit Diff for this PR has been fixed.

@jasonrhodes jasonrhodes merged commit c84248c into elastic:main Sep 27, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @klacabane

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrhodes jasonrhodes jasonrhodes approved these changes

Assignees

@klacabane klacabane

Labels
backport:skip This commit does not require backporting Feature:Asset Manager release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:Observed Asset Management Label used for engineers working on various parts of observed asset management v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[asset manager] hosts endpoint to use metrics_data_access plugin
7 participants
@klacabane @apmmachine @elasticmachine @jasonrhodes @Ikuni17 @kibana-ci @kibanamachine