[Ops] Fix outstanding typescript issues / re-enable typecheck (elasti…

…c#167392) ## Summary This is hopefully the last batch of typescript issues to be fixed, related to elastic#166813. It's also re-enabling full typecheck, with this, we should be back in a clean, typechecked main branch. Blocked by elastic#167428 --------- Co-authored-by: Brad White <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: Thomas Watson <[email protected]> Co-authored-by: Patryk Kopyciński <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
delanni · Sep 28, 2023 · 8a29a5e · 8a29a5e
1 parent 905dcfa
commit 8a29a5e
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 36 deletions.
diff --git a/.buildkite/pipelines/on_merge.yml b/.buildkite/pipelines/on_merge.yml
@@ -154,16 +154,15 @@ steps:
         - exit_status: '-1'
           limit: 3
 
-#  TODO: Enable in #166813 after fixing types
-#  - command: .buildkite/scripts/steps/check_types.sh
-#    label: 'Check Types'
-#    agents:
-#      queue: n2-16-spot
-#    timeout_in_minutes: 60
-#    retry:
-#      automatic:
-#        - exit_status: '-1'
-#          limit: 3
+  - command: .buildkite/scripts/steps/check_types.sh
+    label: 'Check Types'
+    agents:
+      queue: n2-16-spot
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
 
   - command: .buildkite/scripts/steps/storybooks/build_and_upload.sh
     label: 'Build Storybooks'

diff --git a/.buildkite/pipelines/pull_request/base.yml b/.buildkite/pipelines/pull_request/base.yml
@@ -136,13 +136,12 @@ steps:
         - exit_status: '-1'
           limit: 3
 
-# TODO: Enable in #166813 after fixing types
-#  - command: .buildkite/scripts/steps/check_types.sh
-#    label: 'Check Types'
-#    agents:
-#      queue: n2-16-spot
-#    timeout_in_minutes: 60
-#    retry:
-#      automatic:
-#        - exit_status: '-1'
-#          limit: 3
+  - command: .buildkite/scripts/steps/check_types.sh
+    label: 'Check Types'
+    agents:
+      queue: n2-16-spot
+    timeout_in_minutes: 60
+    retry:
+      automatic:
+        - exit_status: '-1'
+          limit: 3
diff --git a/.buildkite/pipelines/pull_request/type_check_selective.yml b/.buildkite/pipelines/pull_request/type_check_selective.yml
diff --git a/.buildkite/scripts/pipelines/pull_request/pipeline.ts b/.buildkite/scripts/pipelines/pull_request/pipeline.ts
@@ -59,12 +59,6 @@ const uploadPipeline = (pipelineContent: string | object) => {
       pipeline.push(getPipeline('.buildkite/pipelines/pull_request/kbn_handlebars.yml'));
     }
 
-    if (GITHUB_PR_LABELS.includes('ci:hard-typecheck')) {
-      pipeline.push(getPipeline('.buildkite/pipelines/pull_request/type_check.yml'));
-    } else {
-      pipeline.push(getPipeline('.buildkite/pipelines/pull_request/type_check_selective.yml'));
-    }
-
     if (
       (await doAnyChangesMatch([
         /^src\/plugins\/controls/,

diff --git a/.buildkite/scripts/steps/check_types_commits.sh b/.buildkite/scripts/steps/check_types_commits.sh
@@ -2,6 +2,10 @@
 
 set -euo pipefail
 
+# This script will collect typescript projects and run typecheck on projects between the given 2 parameters
+# Could be used for selective typechecking on projects that might be affected for a given PR.
+# (The accuracy for finding related projects is not a 100%)
+
 if [[ "${CI-}" == "true" ]]; then
   .buildkite/scripts/bootstrap.sh