-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable type check in api docs build #167839
Merged
Ikuni17
merged 1 commit into
elastic:main
from
Ikuni17:chore/reenable-api-docs-type-check
Oct 2, 2023
Merged
Reenable type check in api docs build #167839
Ikuni17
merged 1 commit into
elastic:main
from
Ikuni17:chore/reenable-api-docs-type-check
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
approved these changes
Oct 2, 2023
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @Ikuni17 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 2, 2023
## Summary This was missed as part of elastic#167392 (cherry picked from commit f6d505a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [Reenable type check in api docs build (#167839)](#167839) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Brad White","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-02T23:18:13Z","message":"Reenable type check in api docs build (#167839)\n\n## Summary\r\n\r\nThis was missed as part of #167392","sha":"f6d505ab5014f7bb757480b86ab2ab3d5fe05d6c","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.11.0"],"number":167839,"url":"https://github.com/elastic/kibana/pull/167839","mergeCommit":{"message":"Reenable type check in api docs build (#167839)\n\n## Summary\r\n\r\nThis was missed as part of #167392","sha":"f6d505ab5014f7bb757480b86ab2ab3d5fe05d6c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167839","number":167839,"mergeCommit":{"message":"Reenable type check in api docs build (#167839)\n\n## Summary\r\n\r\nThis was missed as part of #167392","sha":"f6d505ab5014f7bb757480b86ab2ab3d5fe05d6c"}}]}] BACKPORT--> Co-authored-by: Brad White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
release_note:skip
Skip the PR/issue when compiling release notes
v8.10.3
v8.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was missed as part of #167392