Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event annotations] add more API integration tests #166463

Merged

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Sep 14, 2023

Summary

Covers the event annotations API in tests.

Part of #159053
Part of #161038

@drewdaemon drewdaemon added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes labels Sep 14, 2023
@drewdaemon drewdaemon marked this pull request as ready for review September 14, 2023 14:51
@drewdaemon drewdaemon requested a review from a team as a code owner September 14, 2023 14:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vis team changes LGTM, code review only. Have we run them on FR flaky server?

@drewdaemon
Copy link
Contributor Author

Flaky test runner green for 100 runs: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3161

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
eventAnnotation 195 201 +6

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
eventAnnotation 5 6 +1
Unknown metric groups

API count

id before after diff
eventAnnotation 195 201 +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants