Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event annotations] Increase library annotations functional test coverage #159053

Closed
11 of 21 tasks
drewdaemon opened this issue Jun 5, 2023 · 3 comments
Closed
11 of 21 tasks

[Event annotations] Increase library annotations functional test coverage #159053

drewdaemon opened this issue Jun 5, 2023 · 3 comments
Assignees
@drewdaemon
Labels
chore Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented Jun 5, 2023 •
edited
Loading

Listing page

  • Search (by tag as well)
  • Edit
  • Delete
  • Ad hoc data view?
  • Embeddable recovering from problem data view
  • Embeddable recovering from missing data view
  • Empty prompt navigation

Lens

  • Save to library
  • Add from library
  • Handling deleted group
  • Try to save new group with same title
  • Changes to linked not reflected elsewhere
  • Reverting changes
  • Ad hoc data view?
  • Adding annotation layer from load from library back door

Dashboard

API (completed in #166463)

  • search
  • get
  • create
  • update
  • delete
@drewdaemon drewdaemon added chore Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@drewdaemon drewdaemon added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jun 5, 2023
@drewdaemon drewdaemon self-assigned this Jun 5, 2023
@drewdaemon drewdaemon added technical debt Improvement of the software architecture and operational architecture impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jun 13, 2023
@drewdaemon drewdaemon added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 16, 2023
This was referenced Sep 13, 2023
Merged
Merged
drewdaemon added a commit that referenced this issue Sep 18, 2023
@drewdaemon @kibanamachine
[Event annotations] add more API integration tests (#166463)
6d47334 
## Summary

Covers the event annotations API in tests.

Part of #159053
Part of #161038

---------

Co-authored-by: kibanamachine <[email protected]>
stratoula added a commit that referenced this issue Sep 20, 2023
@drewdaemon @kibanamachine @stratoula
[Event annotations] Individual annotation editing from library (#163346)
172de68 
## Summary

Resolve #158774
Part of #159053

<img width="1920" alt="Screenshot 2023-09-13 at 2 00 25 PM"
src="https://github.com/elastic/kibana/assets/315764/69cfe07e-d442-462b-91c5-395d6040c383">

<img width="1920" alt="Screenshot 2023-09-13 at 2 00 09 PM"
src="https://github.com/elastic/kibana/assets/315764/260aedbe-31d0-415a-b387-10a9b13bf9a6">

<img width="1920" alt="Screenshot 2023-09-13 at 2 01 07 PM"
src="https://github.com/elastic/kibana/assets/315764/9672010b-d49b-4041-acf1-33d3baec1e9a">


### Known issues
- [ ] ~Responsive layout~ **Proposal:** don't optimize for mobile
- [x] Recovering embeddable from problematic data view state
- [x] margin around dimension buttons
- [x] Functional test coverage

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
@drewdaemon drewdaemon changed the title [Event annotations] Increase functional test coverage [Event annotations] Increase library annotations functional test coverage Sep 27, 2023
@drewdaemon
Copy link
Contributor Author

Closing as we feel the FT coverage is strong enough for now. The main flows are covered and we have many unit and component tests for state manipulations and many of the UI interactions that aren't directly triggered in the FTs.

We always have the option to increase end-to-end coverage if we encounter preventable regressions.

The one exception is testing data view switching in the embeddable. The embeddable is currently very difficult to test at the unit level and is therefore prone to regressions.

I will create a separate issue for that case.

@drewdaemon
Copy link
Contributor Author

Issue for data view switching test: #167434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewdaemon drewdaemon

Labels
chore Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drewdaemon @elasticmachine