Skip to content

Commit

Permalink
FTR - Adjust check for successful navigation (#166605)
Browse files Browse the repository at this point in the history
## Summary

This PR adjusts the FTR check for successful navigation to also take
ports on the `appUrl` into account when comparing to `currentUrl` that
already had the ports removed for the comparison.
  • Loading branch information
pheyos authored Sep 18, 2023
1 parent 6561cd2 commit 555dd7e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/functional/page_objects/common_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ export class CommonPageObject extends FtrService {
const navSuccessful = currentUrl
.replace(':80/', '/')
.replace(':443/', '/')
.startsWith(appUrl);
.startsWith(appUrl.replace(':80/', '/').replace(':443/', '/'));

if (!navSuccessful) {
const msg = `App failed to load: ${appName} in ${this.defaultFindTimeout}ms appUrl=${appUrl} currentUrl=${currentUrl}`;
Expand Down

0 comments on commit 555dd7e

Please sign in to comment.