Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event annotations] add more API integration tests #166463

Merged
merged 11 commits into from
Sep 18, 2023
Merged

[Event annotations] add more API integration tests #166463

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0a71ecf
add types to tests
drewdaemon Aug 16, 2023
cffe425
remove unused API create option
drewdaemon Sep 8, 2023
88514ad
add GET API test
drewdaemon Sep 8, 2023
a74d62c
add SEARCH API test
drewdaemon Sep 8, 2023
a80c2e6
add DELETE API test
drewdaemon Sep 8, 2023
3b7719b
add CREATE API test
drewdaemon Sep 8, 2023
d9c6372
UPDATE and DELETE tests
drewdaemon Sep 8, 2023
4e16251
Merge branch 'main' of github.com:elastic/kibana into 159053/increase…
drewdaemon Sep 14, 2023
1b670a0
Merge branch 'main' of github.com:elastic/kibana into 159053/increase…
drewdaemon Sep 18, 2023
faa341d
clean up leftover groups
drewdaemon Sep 18, 2023
3bc1520
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/plugins/event_annotation/common/content_management/v1/cm_services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ const getResultSchema = schema.object(
);

const createOptionsSchema = schema.object({
overwrite: schema.maybe(schema.boolean()),
references: schema.maybe(referencesSchema),
});

Expand Down
2 changes: 0 additions & 2 deletions src/plugins/event_annotation/common/content_management/v1/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ export type EventAnnotationGroupGetOut = GetResult<
// ----------- CREATE --------------

export interface CreateOptions {
/** If a document with the given `id` already exists, overwrite it's contents (default=false). */
overwrite?: boolean;
/** Array of referenced saved objects. */
references?: Reference[];
}
Expand Down
6 changes: 6 additions & 0 deletions src/plugins/event_annotation/common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,16 @@ export type { FetchEventAnnotationsArgs } from './fetch_event_annotations/types'
export type { EventAnnotationArgs, EventAnnotationOutput } from './types';

export type {
EventAnnotationGroupGetIn,
EventAnnotationGroupGetOut,
EventAnnotationGroupSavedObjectAttributes,
EventAnnotationGroupCreateIn,
EventAnnotationGroupCreateOut,
EventAnnotationGroupUpdateIn,
EventAnnotationGroupSearchIn,
EventAnnotationGroupSearchOut,
EventAnnotationGroupDeleteIn,
EventAnnotationGroupDeleteOut,
} from './content_management';
export { CONTENT_ID } from './content_management';
export { ANNOTATIONS_LISTING_VIEW_ID } from './constants';
1 change: 0 additions & 1 deletion src/plugins/event_annotation/server/content_management/event_annotation_group_storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ export class EventAnnotationGroupStorage
const transforms = getTransforms(cmServicesDefinition, requestVersion);
const soClient = await savedObjectClientFromRequest(ctx);

// Save data in DB
const {
saved_object: savedObject,
alias_purpose: aliasPurpose,
Expand Down
Loading