Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Adds note for data source performance impact #127184

Merged
merged 1 commit into from
Mar 8, 2022
Merged

[DOCS] Adds note for data source performance impact #127184

merged 1 commit into from
Mar 8, 2022

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Mar 8, 2022 •
edited
Loading

Summary

Adds the following performance note to the Aggregation-based docs:

There is no performance impact on the data source you select. For example, *Discover* saved searches perform the same as {data-sources}.

Docs preview link: https://kibana_127184.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#create-aggregation-based-panel

@KOTungseth KOTungseth self-assigned this Mar 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @KOTungseth

ThomThomson
ThomThomson approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks great to me! Thank you for doing this so quickly!

@KOTungseth KOTungseth merged commit bb1834d into elastic:main Mar 8, 2022
@KOTungseth KOTungseth deleted the docs/dash-note branch March 8, 2022 21:50
@KOTungseth KOTungseth restored the docs/dash-note branch March 8, 2022 21:51
@KOTungseth KOTungseth added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 8, 2022
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (#127184)
017e0a5 
(cherry picked from commit bb1834d)
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
✅ 8.0
❌ 7.7 Backport failed because of merge conflicts
❌ 7.6 Backport failed because of merge conflicts
❌ 7.10 Backport failed because of merge conflicts
❌ 7.8 Backport failed because of merge conflicts
❌ 7.9 Backport failed because of merge conflicts
❌ 7.11 Backport failed because of merge conflicts
❌ 7.12 Backport failed because of merge conflicts
✅ 7.14
✅ 7.13
✅ 7.15
✅ 7.16
✅ 8.1
✅ 7.17

Manual backport

To create the backport manually run:

node scripts/backport --pr 127184

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (#127184)
f8662f2 
(cherry picked from commit bb1834d)
kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (#127184)
a8b00d6 
(cherry picked from commit bb1834d)
kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (#127184)
eb9b720 
(cherry picked from commit bb1834d)
kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (#127184)
a008cef 
(cherry picked from commit bb1834d)
kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (#127184)
3bf8528 
(cherry picked from commit bb1834d)
kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (#127184)
f70eafa 
(cherry picked from commit bb1834d)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
✅ 8.0
❌ 7.7 Backport failed because of merge conflicts
❌ 7.6 Backport failed because of merge conflicts
❌ 7.10 Backport failed because of merge conflicts
❌ 7.8 Backport failed because of merge conflicts
❌ 7.9 Backport failed because of merge conflicts
❌ 7.11 Backport failed because of merge conflicts
❌ 7.12 Backport failed because of merge conflicts
✅ 7.14
✅ 7.13
✅ 7.15
✅ 7.16
✅ 8.1
✅ 7.17

Manual backport

To create the backport manually run:

node scripts/backport --pr 127184

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 8, 2022
@kibanamachine @KOTungseth
[DOCS] Adds note for data source performance impact (#127184) (#127211)
02cad29 
(cherry picked from commit bb1834d)

Co-authored-by: Kaarina Tungseth <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 8, 2022
@kibanamachine @KOTungseth
[DOCS] Adds note for data source performance impact (#127184) (#127212)
c7205cd 
(cherry picked from commit bb1834d)

Co-authored-by: Kaarina Tungseth <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 8, 2022
@kibanamachine @KOTungseth
[DOCS] Adds note for data source performance impact (#127184) (#127215)
d99a765 
(cherry picked from commit bb1834d)

Co-authored-by: Kaarina Tungseth <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 8, 2022
@kibanamachine @KOTungseth
[DOCS] Adds note for data source performance impact (#127184) (#127214)
64dc858 
(cherry picked from commit bb1834d)

Co-authored-by: Kaarina Tungseth <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 8, 2022
@kibanamachine @KOTungseth
[DOCS] Adds note for data source performance impact (#127184) (#127216)
b56b2d8 
(cherry picked from commit bb1834d)

Co-authored-by: Kaarina Tungseth <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 8, 2022
@kibanamachine @KOTungseth
[DOCS] Adds note for data source performance impact (#127184) (#127217)
69c3a5a 
(cherry picked from commit bb1834d)

Co-authored-by: Kaarina Tungseth <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 9, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/captu…
e2aebde 
…re-browser-errors

* 'main' of github.com:elastic/kibana: (46 commits)
  [Reporting] Capture Kibana stopped error (elastic#127017)
  add updatedAt to SimpleSavedObject (elastic#126359)
  Remove deprecated & unused `ElasticsearchServiceStart.legacy` (elastic#127050)
  remove opacity for fitting line series (elastic#127176)
  Remove deprecated & unused `HttpServiceSetup.auth` (elastic#127056)
  [Lens] Show underlying data editor navigation (elastic#125983)
  Bump dependencies (elastic#127238)
  Remove deprecated & unused `public-AsyncPlugin` (elastic#127048)
  Remove deprecated & unused `SavedObjectsImportFailure.title` (elastic#127043)
  skip flaky suite (elastic#123372)
  [kbn/generate] add basic package generator (elastic#127095)
  [build] Up compression quality (elastic#127064)
  Made fix to broken test. Deleted all existing pipelines before test starts. FLAKY: elastic#118593 (elastic#127102)
  Increase timeout for Jest integration tests (elastic#127220)
  skip failing test suite (elastic#126949)
  [DOCS] Adds note for data source performance impact (elastic#127184)
  [Security Solution] Adds CCS privileges warning enable switch in advanced settings (elastic#124459)
  [App Search] Move to tabbed single tabbed JSON flyout with upload and paste options and refactor cards (elastic#127162)
  Update dependency chromedriver to v99 (elastic#127079)
  [kbn/pm] add timings for more parts of bootstrap (elastic#127157)
  ...

# Conflicts:
#	x-pack/plugins/reporting/common/errors/index.ts
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
kibanamachine added a commit that referenced this pull request Mar 9, 2022
@kibanamachine @KOTungseth
[DOCS] Adds note for data source performance impact (#127184) (#127213)
30f045c 
(cherry picked from commit bb1834d)

Co-authored-by: Kaarina Tungseth <[email protected]>
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 9, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (elastic#127184)
f856e75 
(cherry picked from commit bb1834d)
@KOTungseth KOTungseth mentioned this pull request Mar 9, 2022
Merged
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 9, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (elastic#127184)
bba98df 
(cherry picked from commit bb1834d)
@KOTungseth KOTungseth mentioned this pull request Mar 9, 2022
Merged
KOTungseth added a commit that referenced this pull request Mar 9, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (#127184) (#127314)
87e198c 
(cherry picked from commit bb1834d)
KOTungseth added a commit that referenced this pull request Mar 9, 2022
@KOTungseth
[DOCS] Adds note for data source performance impact (#127184) (#127315)
85d9482 
(cherry picked from commit bb1834d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees

@KOTungseth KOTungseth

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.11.0 v7.12.0 v7.13.0 v7.14.0 v7.15.0 v7.16.0 v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KOTungseth @elasticmachine @kibana-ci @kibanamachine @ThomThomson