Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Up compression quality #127064

Merged
merged 5 commits into from
Mar 8, 2022
Merged

[build] Up compression quality #127064

merged 5 commits into from
Mar 8, 2022

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Mar 7, 2022

This was an experiment to tweak a few of our minifier and compression settings. It didn't have a huge impact, but still seems like it's worthwhile to put through review.

  • Two pass compression with terser - > In some cases more than one pass leads to further compressed code ref
  • Use gzip level 9 instead of 6 for kbn-ui-shared-deps
  • Use brotli level 11 instead of 9 for webpack-compression-plugin

@jbudz jbudz added Team:Operations Team label for Operations Team v8.2.0 backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Mar 7, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 40.6KB 40.6KB -42.0B
apm 2.7MB 2.7MB -3.0KB
canvas 1.0MB 1.0MB -5.5KB
cases 292.4KB 292.1KB -253.0B
charts 42.1KB 41.9KB -244.0B
cloud 15.1KB 15.1KB -1.0B
cloudSecurityPosture 334.3KB 333.6KB -763.0B
console 380.3KB 380.1KB -188.0B
controls 390.3KB 389.8KB -463.0B
core 133.0KB 132.3KB -713.0B
crossClusterReplication 163.2KB 163.1KB -74.0B
dashboard 302.2KB 301.3KB -936.0B
data 116.7KB 116.6KB -60.0B
dataEnhanced 45.5KB 45.4KB -101.0B
dataViewEditor 115.5KB 115.4KB -74.0B
dataViewFieldEditor 148.5KB 148.0KB -558.0B
dataViewManagement 121.5KB 121.1KB -419.0B
dataVisualizer 540.0KB 539.0KB -1.0KB
discover 377.7KB 376.6KB -1.1KB
enterpriseSearch 1.4MB 1.4MB -1.9KB
esUiShared 5.4KB 5.4KB -16.0B
expressionError 13.6KB 13.4KB -106.0B
expressionGauge 9.1KB 9.0KB -48.0B
expressionHeatmap 15.7KB 15.6KB -71.0B
expressionMetricVis 11.0KB 11.0KB -55.0B
expressionPartitionVis 47.0KB 47.0KB -34.0B
expressionRevealImage 1.6KB 1.6KB -30.0B
expressions 45.1KB 44.6KB -487.0B
expressionShape 11.7KB 11.7KB -10.0B
expressionTagcloud 7.7KB 7.7KB -55.0B
fileUpload 824.0KB 821.2KB -2.8KB
fleet 664.5KB 662.7KB -1.7KB
graph 449.5KB 448.5KB -975.0B
home 75.8KB 75.7KB -77.0B
indexLifecycleManagement 148.4KB 148.2KB -155.0B
indexManagement 515.1KB 514.8KB -269.0B
infra 927.2KB 925.9KB -1.4KB
ingestPipelines 452.5KB 452.0KB -511.0B
inputControlVis 77.9KB 77.3KB -575.0B
kibanaReact 212.7KB 212.0KB -667.0B
kibanaUtils 52.1KB 51.6KB -484.0B
lens 1.1MB 1.1MB -2.4KB
licenseManagement 61.2KB 61.1KB -75.0B
lists 147.4KB 146.9KB -545.0B
management 8.5KB 8.5KB -41.0B
maps 2.5MB 2.5MB -2.8KB
mapsEms 81.5KB 81.4KB -194.0B
ml 3.5MB 3.5MB -19.6KB
monitoring 471.6KB 470.7KB -971.0B
observability 395.6KB 394.7KB -922.0B
osquery 950.1KB 949.8KB -247.0B
painlessLab 16.2KB 16.2KB -35.0B
presentationUtil 137.2KB 136.8KB -403.0B
remoteClusters 83.5KB 83.3KB -219.0B
reporting 60.5KB 60.4KB -99.0B
rollup 129.0KB 128.9KB -122.0B
savedObjectsManagement 82.8KB 82.7KB -113.0B
savedObjectsTagging 40.7KB 40.6KB -67.0B
searchprofiler 159.2KB 159.1KB -126.0B
security 494.5KB 493.6KB -898.0B
securitySolution 4.7MB 4.7MB -6.7KB
sessionView 30.9KB 30.9KB -15.0B
sharedUX 100.8KB 100.7KB -145.0B
snapshotRestore 258.4KB 258.3KB -99.0B
spaces 152.3KB 151.9KB -399.0B
stackAlerts 166.9KB 166.8KB -175.0B
timelines 30.6KB 30.6KB -16.0B
transform 375.5KB 375.0KB -463.0B
triggersActionsUi 678.8KB 677.7KB -1.1KB
uiActionsEnhanced 126.9KB 126.7KB -239.0B
upgradeAssistant 168.2KB 167.7KB -576.0B
uptime 743.4KB 742.5KB -837.0B
ux 161.8KB 161.5KB -229.0B
visDefaultEditor 142.5KB 142.4KB -117.0B
visTypeMarkdown 5.5KB 5.5KB -43.0B
visTypeTable 15.7KB 15.7KB -47.0B
visTypeTimelion 121.7KB 120.6KB -1.0KB
visTypeTimeseries 470.6KB 469.8KB -762.0B
visTypeVega 2.0MB 2.0MB -17.4KB
visTypeVislib 351.8KB 351.5KB -290.0B
visTypeXy 60.4KB 60.3KB -65.0B
visualizations 165.1KB 164.3KB -833.0B
watcher 272.6KB 272.5KB -39.0B
total -89.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alerting 38.1KB 38.0KB -6.0B
apm 27.7KB 27.2KB -562.0B
banners 6.5KB 6.5KB -43.0B
bfetch 7.5KB 7.4KB -26.0B
cases 84.3KB 83.7KB -636.0B
charts 58.5KB 58.4KB -112.0B
cloud 8.8KB 8.8KB +1.0B
console 12.1KB 12.1KB -50.0B
controls 20.7KB 20.6KB -50.0B
core 296.0KB 295.7KB -320.0B
crossClusterReplication 11.9KB 11.9KB -8.0B
customIntegrations 6.1KB 6.1KB -7.0B
dashboard 66.0KB 66.0KB -21.0B
dashboardEnhanced 41.8KB 41.3KB -484.0B
data 457.9KB 457.1KB -805.0B
dataEnhanced 9.4KB 9.3KB -4.0B
dataViewEditor 10.7KB 10.6KB -43.0B
dataViewFieldEditor 24.4KB 24.4KB -8.0B
dataViewManagement 4.3KB 4.3KB -4.0B
dataViews 40.2KB 40.2KB -27.0B
dataVisualizer 16.7KB 16.7KB -19.0B
devTools 10.7KB 10.7KB -43.0B
discover 50.7KB 50.5KB -228.0B
discoverEnhanced 5.2KB 5.2KB -8.0B
embeddable 65.2KB 65.1KB -117.0B
embeddableEnhanced 6.5KB 6.5KB -2.0B
esUiShared 122.5KB 122.3KB -149.0B
expressionError 5.1KB 5.0KB -40.0B
expressionGauge 14.5KB 14.5KB -38.0B
expressionHeatmap 13.8KB 13.8KB -35.0B
expressionImage 4.5KB 4.4KB -30.0B
expressionMetric 5.8KB 5.7KB -20.0B
expressionMetricVis 8.9KB 8.8KB -24.0B
expressionPartitionVis 21.5KB 21.4KB -90.0B
expressionRepeatImage 6.3KB 6.3KB -30.0B
expressionRevealImage 6.3KB 6.3KB -23.0B
expressions 87.5KB 87.2KB -296.0B
expressionShape 14.0KB 14.0KB -43.0B
expressionTagcloud 8.9KB 8.8KB -20.0B
fieldFormats 47.8KB 47.7KB -90.0B
fleet 110.3KB 110.2KB -61.0B
globalSearchBar 19.8KB 19.7KB -52.0B
globalSearchProviders 4.6KB 4.6KB -5.0B
indexLifecycleManagement 27.7KB 27.7KB -8.0B
indexManagement 27.2KB 27.2KB -43.0B
infra 89.0KB 88.4KB -581.0B
ingestPipelines 13.4KB 13.3KB -12.0B
inputControlVis 5.4KB 5.4KB -3.0B
inspector 22.6KB 22.6KB -61.0B
interactiveSetup 58.4KB 58.3KB -73.0B
kbnUiSharedDeps-npmDll 4.8MB 4.8MB -7.3KB
kbnUiSharedDeps-srcJs 3.8MB 3.8MB -2.9KB
kibanaOverview 15.5KB 15.5KB -43.0B
kibanaReact 58.9KB 58.7KB -169.0B
kibanaUtils 67.9KB 67.9KB -32.0B
lens 43.8KB 43.7KB -40.0B
licenseManagement 10.2KB 10.2KB -43.0B
licensing 8.6KB 8.6KB -4.0B
logstash 14.3KB 14.2KB -34.0B
maps 66.0KB 65.6KB -456.0B
mapsEms 5.7KB 5.7KB -8.0B
ml 39.2KB 39.0KB -121.0B
monitoring 23.6KB 23.6KB -12.0B
navigation 9.3KB 9.3KB -43.0B
newsfeed 9.7KB 9.7KB -2.0B
observability 87.5KB 87.0KB -514.0B
painlessLab 10.5KB 10.5KB -43.0B
presentationUtil 44.8KB 44.7KB -132.0B
reporting 39.1KB 39.1KB -11.0B
rollup 11.8KB 11.8KB -4.0B
savedObjects 29.1KB 29.0KB -73.0B
savedObjectsManagement 16.3KB 16.3KB -10.0B
screenshotMode 2.0KB 2.0KB -1.0B
searchprofiler 21.5KB 21.5KB -43.0B
security 50.2KB 50.2KB -75.0B
securitySolution 245.6KB 244.5KB -1.0KB
sessionView 61.1KB 61.1KB -21.0B
share 52.9KB 52.9KB -71.0B
sharedUX 4.8KB 4.8KB -8.0B
snapshotRestore 26.7KB 26.6KB -25.0B
spaces 20.3KB 20.3KB -17.0B
stackAlerts 11.9KB 11.9KB -2.0B
telemetry 26.9KB 26.9KB -37.0B
telemetryManagementSection 9.8KB 9.8KB -1.0B
timelines 295.3KB 294.1KB -1.2KB
transform 14.0KB 14.0KB -49.0B
triggersActionsUi 54.2KB 54.1KB -89.0B
uiActions 19.6KB 19.6KB -17.0B
upgradeAssistant 18.9KB 18.9KB -12.0B
uptime 25.3KB 24.8KB -556.0B
urlDrilldown 15.0KB 15.0KB -22.0B
usageCollection 5.0KB 5.0KB -4.0B
visDefaultEditor 19.4KB 19.3KB -20.0B
visTypeGauge 9.7KB 9.7KB -8.0B
visTypeMetric 8.7KB 8.7KB -2.0B
visTypeTable 15.3KB 15.3KB -2.0B
visTypeTimelion 9.8KB 9.8KB -4.0B
visTypeTimeseries 16.2KB 16.1KB -16.0B
visTypeVega 33.0KB 33.0KB -6.0B
visTypeVislib 15.9KB 15.9KB -8.0B
visTypeXy 42.9KB 42.8KB -30.0B
visualizations 44.9KB 44.9KB -13.0B
watcher 13.6KB 13.6KB -43.0B
total -20.6KB
Unknown metric groups

miscellaneous assets size

id before after diff
maps 530.0KB 529.6KB -469.0B
visTypeVega 530.0KB 529.6KB -469.0B
total -938.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Mar 8, 2022

Eh - probably going to close this but I'll open it up as an FYI.

@jbudz jbudz marked this pull request as ready for review March 8, 2022 21:50
@jbudz jbudz requested a review from a team as a code owner March 8, 2022 21:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz merged commit 7923667 into elastic:main Mar 8, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 9, 2022
…re-browser-errors

* 'main' of github.com:elastic/kibana: (46 commits)
  [Reporting] Capture Kibana stopped error (elastic#127017)
  add updatedAt to SimpleSavedObject (elastic#126359)
  Remove deprecated & unused `ElasticsearchServiceStart.legacy` (elastic#127050)
  remove opacity for fitting line series (elastic#127176)
  Remove deprecated & unused `HttpServiceSetup.auth` (elastic#127056)
  [Lens] Show underlying data editor navigation (elastic#125983)
  Bump dependencies (elastic#127238)
  Remove deprecated & unused `public-AsyncPlugin` (elastic#127048)
  Remove deprecated & unused `SavedObjectsImportFailure.title` (elastic#127043)
  skip flaky suite (elastic#123372)
  [kbn/generate] add basic package generator (elastic#127095)
  [build] Up compression quality (elastic#127064)
  Made fix to broken test. Deleted all existing pipelines before test starts. FLAKY: elastic#118593 (elastic#127102)
  Increase timeout for Jest integration tests (elastic#127220)
  skip failing test suite (elastic#126949)
  [DOCS] Adds note for data source performance impact (elastic#127184)
  [Security Solution] Adds CCS privileges warning enable switch in advanced settings (elastic#124459)
  [App Search] Move to tabbed single tabbed JSON flyout with upload and paste options and refactor cards (elastic#127162)
  Update dependency chromedriver to v99 (elastic#127079)
  [kbn/pm] add timings for more parts of bootstrap (elastic#127157)
  ...

# Conflicts:
#	x-pack/plugins/reporting/common/errors/index.ts
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
azasypkin pushed a commit to azasypkin/kibana that referenced this pull request Jun 30, 2023
* [build] Up compression quality

* update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants