Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated & unused SavedObjectsImportFailure.title #127043

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Remove deprecated & unused SavedObjectsImportFailure.title #127043

merged 4 commits into from
Mar 9, 2022

Conversation

afharo
Copy link
Member

@afharo afharo commented Mar 7, 2022 •
edited
Loading

Summary

Part of #121956.

Checklist

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Anything relying on the logs format might be broken Low High There information is still present under meta.title. The parser should be updated accordingly.
External users relying on POST /api/saved_objects/_import might miss the removed field Low High They can obtain the data from meta.title

For maintainers

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.2.0 labels Mar 7, 2022
@afharo afharo force-pushed the remove-unreferenced-apis/SavedObjectsImportFailure.title branch 2 times, most recently from 8848531 to ff392d9 Compare March 7, 2022 16:19
@afharo afharo mentioned this pull request Mar 7, 2022
Closed
6 tasks
@afharo afharo force-pushed the remove-unreferenced-apis/SavedObjectsImportFailure.title branch from ff392d9 to 7f2f728 Compare March 7, 2022 16:48
@afharo afharo force-pushed the remove-unreferenced-apis/SavedObjectsImportFailure.title branch from 7f2f728 to 401c311 Compare March 7, 2022 19:08
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
core 978 976 -2
Unknown metric groups

API count

id before after diff
core 2381 2379 -2

Unreferenced deprecated APIs

id before after diff
core 8 6 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo marked this pull request as ready for review March 8, 2022 00:58
@afharo afharo requested review from a team as code owners March 8, 2022 00:58
@afharo afharo enabled auto-merge (squash) March 8, 2022 09:15
jportner
jportner approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security/Spaces test changes LGTM.

I pulled down the code and tested both import and copy too just to double check that those UIs are unaffected 👍

pgayvallet
pgayvallet approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo afharo merged commit b9b4dc0 into elastic:main Mar 9, 2022
@afharo afharo deleted the remove-unreferenced-apis/SavedObjectsImportFailure.title branch March 9, 2022 07:00
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 9, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/captu…
e2aebde 
…re-browser-errors

* 'main' of github.com:elastic/kibana: (46 commits)
  [Reporting] Capture Kibana stopped error (elastic#127017)
  add updatedAt to SimpleSavedObject (elastic#126359)
  Remove deprecated & unused `ElasticsearchServiceStart.legacy` (elastic#127050)
  remove opacity for fitting line series (elastic#127176)
  Remove deprecated & unused `HttpServiceSetup.auth` (elastic#127056)
  [Lens] Show underlying data editor navigation (elastic#125983)
  Bump dependencies (elastic#127238)
  Remove deprecated & unused `public-AsyncPlugin` (elastic#127048)
  Remove deprecated & unused `SavedObjectsImportFailure.title` (elastic#127043)
  skip flaky suite (elastic#123372)
  [kbn/generate] add basic package generator (elastic#127095)
  [build] Up compression quality (elastic#127064)
  Made fix to broken test. Deleted all existing pipelines before test starts. FLAKY: elastic#118593 (elastic#127102)
  Increase timeout for Jest integration tests (elastic#127220)
  skip failing test suite (elastic#126949)
  [DOCS] Adds note for data source performance impact (elastic#127184)
  [Security Solution] Adds CCS privileges warning enable switch in advanced settings (elastic#124459)
  [App Search] Move to tabbed single tabbed JSON flyout with upload and paste options and refactor cards (elastic#127162)
  Update dependency chromedriver to v99 (elastic#127079)
  [kbn/pm] add timings for more parts of bootstrap (elastic#127157)
  ...

# Conflicts:
#	x-pack/plugins/reporting/common/errors/index.ts
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afharo @kibana-ci @pgayvallet @jportner