[App Search] Move to tabbed single tabbed JSON flyout with upload and paste options and refactor cards #127162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a new shared flyout coming a future commit called JsonFlyout that will conditionally render the tab content that is now housed in these components.
We no longer have text and file and now have json and elasticsearchIndex
Also changes default value for `creationMode` to `api` since `text` was removed
To be completed in a future PR
- Updates the cards to be left rendered instead of a grid - Adds an empty state with illustration for the non-flyout view - Conditionally renders the help text above the buttons in the flyout
Also renames the ones that were changed
scottybollinger
added
release_note:skip
daveyholler
approved these changes
Mar 8, 2022
10:1 error Type export ActiveJsonTab is not a value and should be exported using `export type` @typescript-eslint/consistent-type-exports
Needs to all be in the FormattedMessage component anyway. Original error: https://buildkite.com/elastic/kibana-pull-request/builds/28469#057da46f-28ef-4cdb-8975-8f808757b571
efegurkan
approved these changes
Mar 8, 2022
...ch/public/applications/app_search/components/document_creation/document_creation_buttons.tsx
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flakyMetrics [docs]Module Count
Async chunks
Unknown metric groupsmiscellaneous assets size
History
To update your PR or re-run it, just comment with: |
scottybollinger
added
backport:skip
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 9, 2022
…re-browser-errors * 'main' of github.com:elastic/kibana: (46 commits) [Reporting] Capture Kibana stopped error (elastic#127017) add updatedAt to SimpleSavedObject (elastic#126359) Remove deprecated & unused `ElasticsearchServiceStart.legacy` (elastic#127050) remove opacity for fitting line series (elastic#127176) Remove deprecated & unused `HttpServiceSetup.auth` (elastic#127056) [Lens] Show underlying data editor navigation (elastic#125983) Bump dependencies (elastic#127238) Remove deprecated & unused `public-AsyncPlugin` (elastic#127048) Remove deprecated & unused `SavedObjectsImportFailure.title` (elastic#127043) skip flaky suite (elastic#123372) [kbn/generate] add basic package generator (elastic#127095) [build] Up compression quality (elastic#127064) Made fix to broken test. Deleted all existing pipelines before test starts. FLAKY: elastic#118593 (elastic#127102) Increase timeout for Jest integration tests (elastic#127220) skip failing test suite (elastic#126949) [DOCS] Adds note for data source performance impact (elastic#127184) [Security Solution] Adds CCS privileges warning enable switch in advanced settings (elastic#124459) [App Search] Move to tabbed single tabbed JSON flyout with upload and paste options and refactor cards (elastic#127162) Update dependency chromedriver to v99 (elastic#127079) [kbn/pm] add timings for more parts of bootstrap (elastic#127157) ... # Conflicts: # x-pack/plugins/reporting/common/errors/index.ts # x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/elastic/enterprise-search-team/issues/1300
Summary
This PR implements a new design for the indexing of JSON data in App Search, as well as updates the design of the cards for the engine empty state and indexing flyout.
Also as a part of this PR, a new stubbed-out view for the ElasticsearchIndex indexing component was added for use in this issue.
New tabbed JSON flyout
json.mp4
Stubbed ElasticsearchIndex component
stubbed.ElasticsearchIndex.mp4
Best to follow along by commit with whitespace changes hidden.
Checklist