Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve version type support #123739

Merged
merged 8 commits into from
Jan 28, 2022
Merged

Improve version type support #123739

merged 8 commits into from
Jan 28, 2022

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jan 25, 2022 •
edited
Loading

Summary

close #93248

This pr improves support for semantic version field type in Kibana

Known issues:

How to test

See added functional test

Release notes

Version field type improvements

@Dosant Dosant changed the title D/2022 01 24 version type support Improve version type support Jan 26, 2022
Dosant
Dosant commented Jan 26, 2022
View reviewed changes
src/plugins/data/public/ui/filter_bar/filter_editor/index.tsx
@@ -345,7 +345,7 @@ class FilterEditorUI extends Component<Props, State> {

private renderParamsEditor() {
const indexPattern = this.state.selectedIndexPattern;
if (!indexPattern || !this.state.selectedOperator) {
if (!indexPattern || !this.state.selectedOperator || !this.state.selectedField) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logically it couldn't happen that we had selectedOperator without a selectedField, but I wanted to clarify this here because children now have field as required

src/plugins/data/public/ui/filter_bar/filter_editor/lib/filter_editor_utils.ts
});
}

export function validateParams(params: any, type: string) {
switch (type) {
export function validateParams(params: any, field: IFieldType) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we need to check against field.esTypes now, I am passing the whole field object

@Dosant Dosant marked this pull request as ready for review January 26, 2022 14:09
@Dosant Dosant requested review from a team as code owners January 26, 2022 14:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@Dosant Dosant requested a review from ppisljar January 26, 2022 14:10
ppisljar
ppisljar approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dosant
Copy link
Contributor Author

Dosant commented Jan 27, 2022

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Jan 27, 2022

ACK, will review

kertal
kertal approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested a-la-carte, works as expected

Discover isn't consistent in usage. TODO: create issue for discover

Agreed, didn't have time to look into it, so creating an issue is appreciated 👍

@Dosant
Copy link
Contributor Author

Dosant commented Jan 28, 2022

@elasticmachine merge upstream

@Dosant Dosant mentioned this pull request Jan 28, 2022
Closed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 520 527 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
data 108.4KB 116.6KB +8.2KB
dataVisualizer 539.4KB 539.5KB +30.0B
discover 330.3KB 330.4KB +180.0B
graph 448.4KB 448.4KB +30.0B
lens 1.0MB 1.0MB +30.0B
maps 2.5MB 2.5MB +30.0B
osquery 941.2KB 941.3KB +60.0B
presentationUtil 135.1KB 135.1KB +30.0B
securitySolution 4.6MB 4.6MB +30.0B
stackAlerts 166.6KB 166.7KB +30.0B
total +8.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 449.0KB 449.1KB +90.0B
Unknown metric groups

References to deprecated APIs

id before after diff
data 485 492 +7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 2f46899 into elastic:main Jan 28, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 28, 2022
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022
@Dosant @awahab07
Improve version type support (elastic#123739)
94f55a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Filters release_note:enhancement v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for semantic version data type in index patterns, aggregations, and Lens
6 participants
@Dosant @elasticmachine @kertal @kibana-ci @ppisljar @kibanamachine