Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Add tokenVersion #5520

Closed
Dosant opened this issue Jan 6, 2022 · 5 comments · Fixed by #5553
Closed

[EuiIcon] Add tokenVersion #5520

Dosant opened this issue Jan 6, 2022 · 5 comments · Fixed by #5553

Comments

@Dosant
Copy link
Contributor

Dosant commented Jan 6, 2022

In Kibana we would like to improve support for fields of semantic version type:

Would be nice to have a new token in EUI for this type of field: https://eui.elastic.co/#/display/icons#tokens,
Visually, I think it should somehow be related to semantic version "syntax" e.g.: 1.* or v1

By coincidence tokenVariable could be a decent fit (v) until something specific is implemented.

@elizabetdev
Copy link
Contributor

Thanks, @Dosant for opening this issue.

I'm going to explore some ideas and then I can share the designs here. After that, we can decide what works best and add the new token to EUI.

@elizabetdev elizabetdev self-assigned this Jan 6, 2022
@elizabetdev
Copy link
Contributor

Hi @Dosant,

I started exploring some ideas and this is the design rationale:

  • I tried to avoid having numbers. Because it could confuse users to think that's the actual version.
  • I tried to just use letters and symbols
  • It has to look good in a 16px size. So more of two elements don't work.

Based on this rationale I ended up with 4 versions:
Frame 3@2x

My favorite version and the one I believe it works better is the version 4:

tokenVersion@2x

Let me know if you agree to use version 4, or if you think any of the other versions work better.

@Dosant
Copy link
Contributor Author

Dosant commented Jan 20, 2022

@miukimiu, thanks! I agree with the reasoning and also like version 4 the most 👍

I've also just thought about one more option: existing tokenTag. A tag is a label and a version is basically also a label (a label with some rules).

Screen Shot 2022-01-20 at 15 17 13

What do you think about this one?

@elizabetdev
Copy link
Contributor

@Dosant yes, the tokenTag works well for indicating a version. For example, GitHub uses it:

Screenshot 2022-01-20 at 15 08 35

And since PR #5251 this icon is no longer being used in Kibana. I did a quick search on the Kibana repo.
So I would go for it! 🎉

But when I look at this tokenTag design I'm not sure I would straightway say that it is a tag. So what do you think of improving the design to make it look more like a tag with a circle inside instead of a rectangle? See tag v2.

tokenTag@2x

@Dosant
Copy link
Contributor Author

Dosant commented Jan 20, 2022

But when I look at this tokenTag design I'm not sure I would straightway say that it is a tag. So what do you think of improving the design to make it look more like a tag with a circle inside instead of a rectangle? See tag v2.

@miukimiu, I like it! :)

I'll then start using tokenTag in Kibana in elastic/kibana#93248 while you're making it nicer in EUI 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants