-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiIcon] Add tokenVersion
#5520
Comments
Thanks, @Dosant for opening this issue. I'm going to explore some ideas and then I can share the designs here. After that, we can decide what works best and add the new token to EUI. |
Hi @Dosant, I started exploring some ideas and this is the design rationale:
Based on this rationale I ended up with 4 versions: My favorite version and the one I believe it works better is the version 4: Let me know if you agree to use version 4, or if you think any of the other versions work better. |
@Dosant yes, the And since PR #5251 this icon is no longer being used in Kibana. I did a quick search on the Kibana repo. But when I look at this |
@miukimiu, I like it! :) I'll then start using |
In Kibana we would like to improve support for fields of semantic version type:
Would be nice to have a new token in EUI for this type of field: https://eui.elastic.co/#/display/icons#tokens,
Visually, I think it should somehow be related to semantic version "syntax" e.g.:
1.*
orv1
By coincidence
tokenVariable
could be a decent fit (v
) until something specific is implemented.The text was updated successfully, but these errors were encountered: