[EuiToken] Updated tokenTag design
#5553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5553/ |
cchaos
reviewed
Feb 3, 2022
There was a problem hiding this comment.
This PR LGTM 👍
I just noticed one thing while checking across the themes. It looks like Amsterdam has a higher border-radius than the legacy theme. I think this higher border radius makes it harder to distinguish between square and circle outer shapes. Would you mind bumping this radius down to be the same for both themes?
Amsterdam:
Legacy:
elizabetdev
force-pushed
the
update-tokenTag
branch
from
0359607 to
c9d4a81
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5553/ |
|
Thanks @cchaos, the border radius is now the same in both themes. I updated the screenshots on the PR description to reflect these changes. 👍🏽 |
cchaos
approved these changes
Feb 7, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5553/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updated the
tokenTagdesign to look more like a tag. Closes #5520.The
tokenTagis currently not being used in our products so this gives us an opportunity to update the design without causing any harm.After a few iterations, trying to design a new token icon to represent a semantic version we decided to use the
tokenTag. But without the right context, the old design didn't look like a tag. So we decided to update it.Design
For the design, I basically used the old token. But now it has a more rectangular shape to look more like a tag. Also, I removed the inner rectangle and replaced it with a circle.
Light and dark themes
Checklist