-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiIcon] Add tokenDimension
#7232
Comments
@MichaelMarcialis or @andreadelrio, do you mind responding to or taking this? |
Given that We could do something like this and instead of the V use a D. @dej611 what do you think? |
It would be nice to hint to time series somehow next to the |
@dej611: A while back, we added TSDB-specific tokens for gauge and counter metric fields. Is this request for a higher-level time series field token? Or would these tokens account for your needs here? |
The time series dimension is the complementary part of a time series metric, like a counter or a gauge: i.e. if you have multiple sensors for measuring the temperature somewhere, then temperature would be the
I like this idea, but as you said the |
Hey all, any updates on this issue? |
I would put this discussion on hold for the moment as there have been few changes in discussion and the outcome of such discussion can have an effect on how and what to define as "time series dimension". |
Would you mind if we closed this as not planned for now, and we can re-open it later if needed? |
sure 👍 |
@JasonStoltz the topic clarified a bit recently, so I think it is time to resurrect this issue. Do you mind to reopen this? |
@dej611 Could we post what the final direction/design for the icon should be before re-opening? Or alternatively, if a designer simply wants to open a PR with |
I think the design from @andreadelrio was on a good track. The clock icon was a bit too big IMHO. |
@andreadelrio @MichaelMarcialis do either of you mind chiming in here before re-opening? Or alternatively @dej611 do you mind writing a bit more about what exactly was clarified on this topic? |
The clarification happened more on our side, so no more to add on here. Let me make an example, say there are log records, metrics are extracted from here, and few dimensions can be defined as So here's some thinking point:
This is a full brain dump of the problem as best as I can do. |
Thanks for the context Marco, re-opening. Would appreciate it if a designer could take it from here. |
@MichaelMarcialis @andreadelrio Any chance we could get this looked at? Or know a designer we could assign this to? |
@andreadelrio, did you wish to continue working with @dej611 on your |
Hey, @dej611. I've put together some tokens for this issue. In addition to the requested TSDB Options A and B explore the letter concept you and @andreadelrio proposed earlier. Option C takes a more abstract approach, using a folder icon to convey grouping/categorization, and a bar chart indicating only increasing cumulative values (counter) or values going both up and down (gauge). Let me know if any of these options hit the mark. Thanks! Actual SizeOption AOption BOption CZoomed InOption AOption BOption C |
@dej611: When you get a moment, would you mind responding to the comment above on which (if any) of the options you'd like to proceed with? Thanks! |
Sorry, missed the previous comment. |
In Kibana we would like to improve support for fields of [time series dimension] type: (https://www.elastic.co/guide/en/elasticsearch/reference/current/tsds.html#time-series-dimension):
elastic/kibana#163323
PR: elastic/kibana#163382
Would be nice to have a new token in EUI for this type of field: https://eui.elastic.co/#/display/icons#tokens,
Visually, I think it should somehow be related to a tag or a label, but this is already taken by the
version
field type: #5520The text was updated successfully, but these errors were encountered: