Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedFieldList] Add time series dimension as new type #163382

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Aug 8, 2023

Summary

PoC for #163323

Screenshot 2023-08-08 at 11 22 00 Screenshot 2023-08-08 at 11 15 48 Screenshot 2023-08-08 at 11 15 41 Screenshot 2023-08-08 at 11 15 36

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Aug 8, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 29, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/unified-field-list 277 278 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 594.8KB 595.6KB +807.0B
apm 3.7MB 3.7MB +807.0B
dataVisualizer 613.4KB 613.7KB +257.0B
discover 565.9KB 567.2KB +1.2KB
enterpriseSearch 2.6MB 2.6MB +44.0B
eventAnnotationListing 197.3KB 197.6KB +303.0B
graph 387.7KB 387.8KB +44.0B
indexManagement 553.0KB 553.1KB +44.0B
lens 1.4MB 1.4MB +1.3KB
maps 2.8MB 2.8MB +44.0B
ml 3.5MB 3.5MB +851.0B
presentationUtil 74.4KB 74.5KB +44.0B
securitySolution 12.8MB 12.8MB +44.0B
stackAlerts 202.8KB 202.8KB +44.0B
unifiedDocViewer 57.6KB 57.9KB +303.0B
unifiedSearch 215.2KB 215.2KB +44.0B
total +6.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
osquery 51.2KB 51.3KB +44.0B
Unknown metric groups

API count

id before after diff
@kbn/unified-field-list 304 305 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dej611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:UnifiedFieldList The unified field list component used by Lens & Discover Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants