Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] <FieldIcon/> usage is inconsistent #124017

Closed
Dosant opened this issue Jan 28, 2022 · 6 comments · Fixed by #129621
Closed

[Discover] <FieldIcon/> usage is inconsistent #124017

Dosant opened this issue Jan 28, 2022 · 6 comments · Fixed by #129621
Assignees
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@Dosant
Copy link
Contributor

Dosant commented Jan 28, 2022

Kibana version: Main (8.1)

Describe the bug:

Looks like logic for extracting type from a field for <FieldIcon/> is different in different places in discover.
For example, discover's document table always displays string fields icons as string, but the field list displays an underlying es type (e.g. version or text)

Steps to reproduce:

  1. Create a field of type version or text
  2. See how it is displayed in Discover in the field list and in the document grid.
  3. They are displayed differently

Expected behavior:

They should be displayed in the same manner in different places.

Screenshots (if relevant):

image

Any additional context:

Noticed in: #123739

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jan 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mbondyra
Copy link
Contributor

mbondyra commented Apr 5, 2022

Do we know which icon should be used?

@Dosant
Copy link
Contributor Author

Dosant commented Apr 5, 2022

Specifically for the version field, the icon in the left-field list is correct.

I think we need to compare how FieldIcon is used on the left and on the right and make the usage on the right the same as on the left

@drewdaemon
Copy link
Contributor

@mbondyra are you thinking of taking this one?

@mbondyra
Copy link
Contributor

mbondyra commented Apr 6, 2022

@andrewctate you can take it, I am still working on something else 👌🏼

@kertal
Copy link
Member

kertal commented Apr 6, 2022

@elastic/kibana-data-discovery 🍰 for you both, no matter who takes care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience :DataDiscovery/fix-it-week Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants