[Discover] make field icons consistent across field list and doc tables

[drewdaemon]

Summary

Fixes #124017

Makes icons in the doc viewer tables match the fields list.

Modern

Legacy

Testing help

1. Create an index with a version field and give it a document

PUT test_icons
{
  "mappings": {
    "properties": {
      "my_version": {
        "type": "version"
      }
    }
  }
}

POST test_icons/_doc
{
  "my_version": "1.5"
}

2. Create data view

3. View the document in Discover

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[kertal]

Thx so much! Now the icons is displayed correctly 👍 Added a request for refactoring to our utils folder for shared code, also saw some code as comment ready for a cleanup.

Note to myself: we currently have 2 ways in the code to get the label of the icon, version field's label in the DocViewer table is unknown therefore. We should also refactor this to a nice helper function in out utils folder to have a single point of 'failure', but that can be done in a follow up PR, there's another PR inflight working with field types , so there a good opportunity to simplify after that : #126657

[drewdaemon]

You got it @kertal ! Updated the PR with your requests.

[kertal]

Thx so much Andrew, LGTM , tested locally and works as expected 👍

[drewdaemon]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: a08959f
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
discover	445	446	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
discover	400.5KB	400.7KB	+252.0B

History

• 💛 Build #36928 was flaky e5c6912
• 💛 Build #36589 was flaky 6beae2d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation