disable suggestions for version fields

elastic · Jan 26, 2022 · 69e47bb · 69e47bb
1 parent 7659bf6
commit 69e47bb
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/plugins/data/public/autocomplete/providers/value_suggestion_provider.ts b/src/plugins/data/public/autocomplete/providers/value_suggestion_provider.ts
@@ -103,9 +103,16 @@ export const setupValueSuggestionProvider = (
       useTimeRange ?? core!.uiSettings.get<boolean>(UI_SETTINGS.AUTOCOMPLETE_USE_TIMERANGE);
     const { title } = indexPattern;
 
+    const isVersionFieldType = field.type === 'string' && field.esTypes?.includes('version');
+
     if (field.type === 'boolean') {
       return [true, false];
-    } else if (!shouldSuggestValues || !field.aggregatable || field.type !== 'string') {
+    } else if (
+      !shouldSuggestValues ||
+      !field.aggregatable ||
+      field.type !== 'string' ||
+      isVersionFieldType // suggestions don't work for version fields
+    ) {
       return [];
     }
 

diff --git a/src/plugins/data/public/ui/filter_bar/filter_editor/phrase_suggestor.tsx b/src/plugins/data/public/ui/filter_bar/filter_editor/phrase_suggestor.tsx
@@ -54,7 +54,15 @@ export class PhraseSuggestorUI<T extends PhraseSuggestorProps> extends React.Com
       UI_SETTINGS.FILTERS_EDITOR_SUGGEST_VALUES
     );
     const { field } = this.props;
-    return shouldSuggestValues && field && field.aggregatable && field.type === 'string';
+    const isVersionFieldType = field?.esTypes?.includes('version');
+
+    return (
+      shouldSuggestValues &&
+      field &&
+      field.aggregatable &&
+      field.type === 'string' &&
+      !isVersionFieldType // suggestions don't work for version fields
+    );
   }
 
   protected onSearchChange = (value: string | number | boolean) => {