Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] [Timelines] Reduce number of alerts per page in Alerts table #111100

Closed
wants to merge 9 commits into from
Closed

[Observability] [Timelines] Reduce number of alerts per page in Alerts table #111100

wants to merge 9 commits into from

Conversation

miltonhultgren
Copy link
Contributor

Summary

Part of #110758

While we wait for elastic/eui#5116 and elastic/eui#5115 to make it into Kibana we will limit the alerts table to only show 10 rows per page to work around the performance issues.

When there are a lot of alerts, we only show 10 items per page, we should the pages but no option to change the page size.

Screenshot 2021-09-03 at 11 24 48

Checklist

@miltonhultgren miltonhultgren added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Theme: rac label obsolete v7.15.0 v7.16.0 labels Sep 3, 2021
@miltonhultgren miltonhultgren self-assigned this Sep 3, 2021
@miltonhultgren
Copy link
Contributor Author

I would love some feedback on where to add tests for this.

@miltonhultgren miltonhultgren mentioned this pull request Sep 3, 2021
Closed
@miltonhultgren miltonhultgren requested a review from a team September 3, 2021 10:52
@miltonhultgren miltonhultgren marked this pull request as ready for review September 3, 2021 10:52
@miltonhultgren miltonhultgren requested a review from a team as a code owner September 3, 2021 10:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@miltonhultgren
Copy link
Contributor Author

@elasticmachine merge upstream

@weltenwort
Copy link
Member

🤔 These test failures look unrelated.

@miltonhultgren miltonhultgren force-pushed the 110758-limit-alerts-table-size branch from c038960 to 601b4f2 Compare September 7, 2021 06:56
@miltonhultgren
Copy link
Contributor Author

Yes, they seem to be API test failures. I will trigger another build and see if it persists.

matschaffer
matschaffer reviewed Sep 7, 2021
View reviewed changes
x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx
@@ -370,7 +375,8 @@ export function AlertsTableTGrid(props: AlertsTableTGridProps) {
filters: [],
hasAlertsCrudPermissions,
indexNames,
itemsPerPageOptions: [10, 25, 50],
itemsPerPage: 10,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to have a comment regarding why we only have 10. If there's an issue covering the EUI update maybe reference that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment!

matschaffer
matschaffer approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it

@matschaffer
Copy link
Contributor

#110918 looks fixed, so pulling master to try to get the build green

@matschaffer
Copy link
Contributor

@elasticmachine merge upstream

@miltonhultgren
Copy link
Contributor Author

@elastic/security-threat-hunting Can you leave your opinions on this? :)

@kqualters-elastic
Copy link
Contributor

@miltonhultgren code lgtm. However I don't think this is really needed after the update to Eui, the performance seems much, much better even with 100 rows in 7.15. I'm not sure when the change will make it's way into master, I've only seen the upgrade in 7.15 so far. The fix is in [email protected], and master is still on [email protected]. @chandlerprall do you know when the tabbable change will make it into kibana master branch?

@chandlerprall
Copy link
Contributor

do you know when the tabbable change will make it into kibana master branch?

Upgrading to the version immediately prior right now, waiting on reviews: #110998

As soon as that's in we'll bump to 37.6.2 which only contains the two grid performance items. Should be next Wednesday-ish?

@miltonhultgren
Copy link
Contributor Author

Closing since EUI performance improvements are soon to land!

@miltonhultgren
Copy link
Contributor Author

Re-opening in light of elastic/eui#5162

@miltonhultgren
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
timelines 847 848 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 555.6KB 555.6KB +8.0B
timelines 420.0KB 420.1KB +21.0B
total +29.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
timelines 25 24 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 311.8KB 312.3KB +526.0B
Unknown metric groups

API count

id before after diff
timelines 968 969 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @miltonhultgren

@miltonhultgren
Copy link
Contributor Author

Pinging @elastic/security-threat-hunting, could I get a code owner review on this? :)

@kqualters-elastic kqualters-elastic mentioned this pull request Sep 11, 2021
Closed
@miltonhultgren
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@miltonhultgren
Copy link
Contributor Author

Issues might have been fixed (again) in elastic/eui#5163, holding off with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@matschaffer matschaffer matschaffer approved these changes

Assignees

@miltonhultgren miltonhultgren

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@miltonhultgren @elasticmachine @weltenwort @matschaffer @kqualters-elastic @chandlerprall @kibanamachine