Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Changing the size of columns to change the set that are currently viewable triggers many, many calls to tabble #5162

Closed
Tracked by #5167
kqualters-elastic opened this issue Sep 9, 2021 · 3 comments · Fixed by #5163

Comments

@kqualters-elastic
Copy link
Contributor

kqualters-elastic commented Sep 9, 2021

Sort of a continuation of the issue described in #5115 , whenever a user changes the set of columns that are currently viewable by resizing one, either by expanding a column so that another is pushed out of the table viewport or by shrinking a column so that another comes into view that was not previously, the number of calls to the tabbable library become prohibitively expensive for 50 or 100 rows of data.
image
image

A similar flamegraph can be seen on https://elastic.github.io/eui/#/tabular-content/data-grid

@paulewing
Copy link

Thank you for raising this issue @kqualters-elastic. I would agree that this is a priority as I would expect users to frequently adjust column sizes to account for various field character lengths.

@mchopda
Copy link

mchopda commented Sep 10, 2021

Agree @paulewing. Thank you for confirming the priority.

@kqualters-elastic
Copy link
Contributor Author

After @chandlerprall 's awesome work with #5163 , I've tested the table again and the difference is night and day
image
So much so that I no longer think we need to do elastic/kibana#111899 or elastic/kibana#111100 performance is good when using every interaction in EuiDataGrid that I'm aware of, even with 100 rows. @paulewing @XavierM @mchopda what do y'all think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants