Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v37.6.0 #110998

Merged
merged 18 commits into from
Sep 9, 2021
Merged

Upgrade EUI to v37.6.0 #110998

merged 18 commits into from
Sep 9, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Sep 2, 2021 •
edited
Loading

Summary

[email protected] ⏩ [email protected]

37.6.0

  • Updated EuiSuperDatePicker to pass a data-test-subj prop (#5085)
  • Added euiTextBreakWord() mixin to the euiTitle() mixin to ensure all titles break long words (#5107)
  • Added euiTextBreakWord() to EuiFormLabels (#5107)

Bug fixes

  • Fixed EuiSuperSelect's focus keyboard behavior when no initial value is passed, and focus label behavior (#5097)
  • Fixed EuiSelectable sometimes requiring two clicks to change selection (#5117)

37.5.0

Feature: Emotion (#4511)

  • Added EuiThemeProvider, a React context provider for theme values and color mode selection
  • Added useEuiTheme React hook, and withEuiTheme React HOC for consuming the EuiTheme
  • Added global EuiTheme tokens for colors, size, font, border, animation, and breakpoint
  • Added color services for makeHighContrastColor, makeDisabledContrastColor, shade, tint, transparentize, saturate, desaturate, lightness

37.4.0

  • Updated EuiToolTip to remain showing tooltip while child element is in focus (#5066)
  • Removed children from TypeScript definition in EuiIconTip (#5066)
  • Removed children as a possible prop on EuiTreeView (#5053)
  • Updated elastic-charts theme with better text colors, font stack and goal styles (#5077)

Bug fixes

  • Fixed location of default value of EuiToolTip's display prop (#5066)
  • Fixed instance of EuiScreenReader text being exposed in EuiDataGrid sorting menu (#5084)
  • Fixed default value of EuiPagination's activePage to target first page (#5053)
  • Fixed screen reader text from displaying in some EuiDataGrid cell popovers (#5087)
  • Fixed EuiDatePicker year dropdown when configured with minDate and/or maxDate (#5069)
  • Fixed EuiDatePicker's clear icon overlaying date text (#5095)

Theme: Amsterdam

  • Reduced EuiNotificationBadge border-radius to small (#5053)
  • Fixed hover and focus states of EuiFacet to match established pattern (#5053)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.16.0 labels Sep 2, 2021
@pgayvallet pgayvallet mentioned this pull request Sep 3, 2021
Closed
@thompsongl thompsongl marked this pull request as ready for review September 7, 2021 17:46
@thompsongl thompsongl requested review from a team as code owners September 7, 2021 17:46
@thompsongl thompsongl requested a review from a team September 7, 2021 17:46
@thompsongl thompsongl requested a review from a team as a code owner September 7, 2021 17:46
@thompsongl thompsongl requested review from a team as code owners September 7, 2021 17:46
@thompsongl thompsongl requested a review from a team September 7, 2021 17:46
@thompsongl thompsongl requested a review from a team as a code owner September 7, 2021 17:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

smith
smith approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM snapshot changes look ok.

shahzad31
shahzad31 approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM,

Only few snapshots are updated.

@chandlerprall chandlerprall mentioned this pull request Sep 8, 2021
Closed
1 task
peteharverson
peteharverson approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML edits LGTM

@thompsongl
Copy link
Contributor Author

Remaining codeowner reviews are for snapshot updates only. Will merge on next successful CI run

kertal
kertal approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, data discovery code was just touched by new snapshots

@cee-chen
Copy link
Contributor

cee-chen commented Sep 9, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.6MB 1.6MB +360.0B
maps 3.2MB 3.2MB +360.0B
visTypeTimeseries 1004.2KB 1004.7KB +544.0B
total +1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 184.4KB 184.7KB +360.0B
kbnUiSharedDeps-css 535.0KB 537.9KB +2.9KB
kbnUiSharedDeps-elastic 2.6MB 2.7MB +49.5KB
kbnUiSharedDeps-js 6.5MB 6.5MB +3.6KB
total +56.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit 6803fb3 into elastic:master Sep 9, 2021
@thompsongl thompsongl mentioned this pull request Sep 9, 2021
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Sep 9, 2021
@thompsongl @kibanamachine
Upgrade EUI to v37.6.0 (elastic#110998)
c974885 
* eui to 37.6.0

* update snapshots

* grid cell text

* update snapshot

* Revert "grid cell text"

This reverts commit 1721e83.

* grid cell text

* update tsvb baseline

* update area_chart baseline

Co-authored-by: Kibana Machine <[email protected]>
thompsongl added a commit that referenced this pull request Sep 9, 2021
@thompsongl @kibanamachine
Upgrade EUI to v37.6.0 (#110998) (#111799)
77a26da 
* eui to 37.6.0

* update snapshots

* grid cell text

* update snapshot

* Revert "grid cell text"

This reverts commit 1721e83.

* grid cell text

* update tsvb baseline

* update area_chart baseline

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@jbudz jbudz jbudz approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@kertal kertal kertal approved these changes

@smith smith smith approved these changes

@matschaffer matschaffer matschaffer approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.