-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency @elastic/charts to v34 #5077
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Jenkins test this please |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/ |
Jenkins test this please |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/ |
🎉 Thanks @nickofthyme !!
Can you point me to the right theme settings to set these colors? I'd like to fix that goal chart example which right now doesn't flip between light and dark mode. |
Nm, I found it! Having the changelog in the PR summary is really nice. |
Ah wait sorry, yes, I found the |
Bullet, gauge and goal should all share the same theme options via |
Hmm I'll push up my changes and then can you check I added the theme keys right? |
- Bullet chart still doesn’t seem to be getting the new theme colors
Jenkins test this please |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/ |
… version of color palette on bullet graph
This comment has been minimized.
This comment has been minimized.
Jenkins, test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!! I'll check in the browsers once we have PR build. I think this process will keep us in sync way better.
Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/ |
Jenkins test this please |
Jenkins test this please |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/ |
Jenkins test this please |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5077/ |
This PR contains the following updates:
^33.0.1
->^34.2.0
Release Notes
elastic/elastic-charts
v34.2.0
Compare Source
Bug Fixes
Features
34.1.1 (2021-08-20)
Bug Fixes
v34.1.1
Compare Source
Bug Fixes
v34.1.0
Compare Source
Bug Fixes
Features
v34.0.0
Compare Source
Code Refactoring
BREAKING CHANGES
TextStyle.fontStyle
is no longer astring
, it's the more specificFontStyle
fontStyle
in word cloud is also switching fromstring
toFontStyle
fill
andtextColor
for the text color;fill
got removed, becausetextColor
is part of the publicFont
type, and becausetextColor
has clearer meaning thanfill
. Yet, some of the code used thefill
property and/or made thefill
property also mandatory. So, userland code needs to remove somefill
property, and might need to ensure that the correct value is going intotextColor
getRadians
got unpublished33.2.4 (2021-08-16)
Bug Fixes
33.2.3 (2021-08-16)
Bug Fixes
33.2.2 (2021-08-10)
Bug Fixes
33.2.1 (2021-08-09)
Bug Fixes
v33.2.4
Compare Source
Bug Fixes
v33.2.3
Compare Source
Bug Fixes
v33.2.2
Compare Source
Bug Fixes
v33.2.1
Compare Source
Bug Fixes
v33.2.0
Compare Source
Bug Fixes
Features
v33.1.0
Compare Source
Bug Fixes
Features
33.0.2 (2021-07-20)
Bug Fixes
33.0.1 (2021-07-16)
Bug Fixes
v33.0.2
Compare Source
Bug Fixes
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled due to failing status checks.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.