Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] cell actions are always rendered #5116

Closed
Tracked by #5083
chandlerprall opened this issue Aug 31, 2021 · 1 comment · Fixed by #5120
Closed
Tracked by #5083

[EuiDataGrid] cell actions are always rendered #5116

chandlerprall opened this issue Aug 31, 2021 · 1 comment · Fixed by #5120
Assignees

Comments

@chandlerprall
Copy link
Contributor

I believe this is a regression. Rendering cell actions requires creating multiple new elements per cell, times the visible cells, equals slower React&application performance especially as the grid is instantiating. The cell actions should not be included in the DOM unless they are [becoming] visible/interactive.

@chandlerprall
Copy link
Contributor Author

Correction: cell actions are not rendered by default, but we don't clear the enableInteractions state after the mouse leaves the cell so they accumulate on the DOM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant