Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to rename visualizations in the Viz app #7720

Closed
robin13 opened this issue Jul 12, 2016 · 10 comments
Closed

Ability to rename visualizations in the Viz app #7720

robin13 opened this issue Jul 12, 2016 · 10 comments
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement v5.2.0

Comments

@robin13
Copy link
Contributor

robin13 commented Jul 12, 2016

Currently to rename an object you must open (e.g. Visualisation), then save under new name, then navigate to settings, find and delete old object.
It would be very helpful to be able to rename objects in the context where they are saved.

@Bargs
Copy link
Contributor

Bargs commented Jul 14, 2016

Does the title input not do what you want?

screen shot 2016-07-14 at 6 01 52 pm

@robin13
Copy link
Contributor Author

robin13 commented Jul 15, 2016

@Bargs I guess this is one option, but it's a long navigation to get to here when most work is done in the Visualisation tab.

@Bargs Bargs changed the title Ability to rename objects Ability to rename visualizations in the Viz app Jul 15, 2016
@Bargs
Copy link
Contributor

Bargs commented Jul 15, 2016

@robin13 ah gotcha, makes sense. I've edited the title to make this more clear.

@Bargs Bargs added P3 and removed feedback_needed labels Jul 15, 2016
@pemontto
Copy link

Editing the title takes the user down a bad path. When you update the title Kibana doesn't update the document _id. So when you go to edit your newly titled visualisation from a dashboard then save it, it's saved under a new _id representative of the new title, it doesn't overwrite the old _id. So your dashboard is still pointing to the old _id and the user is wondering why nothing is changing. And because they share the same title it's very difficult to tell which visualisation is which from the Kibana interface

Pretty sure there is an issue relating to this somewhere in the ~1000 open issues.

@tbragin
Copy link
Contributor

tbragin commented Aug 1, 2016

I believe this is a dup of #2735

@tbragin tbragin closed this as completed Aug 1, 2016
@Bargs
Copy link
Contributor

Bargs commented Aug 1, 2016

@tbragin my understanding is that this ticket is really just asking for a UI enhancement to allow changing the title of a viz from the viz editor, without having to navigate to the saved objects page and edit the title. This doesn't touch on handling the complexities of dashboard/viz relationships.

@tbragin
Copy link
Contributor

tbragin commented Aug 1, 2016

I see that you're right, but I struggle to see how we'd fix one interaction without addressing the other.

@Bargs
Copy link
Contributor

Bargs commented Aug 1, 2016

Dashboards are linked to visualizations by ID, not title. So if we expose title editing capabilities in the viz editor people will be able to change the display name of a viz without changing its ID, which will leave any linked dashboards unaffected by the change. The steps listed in the issue you linked to change both the viz title and ID, which is where things get more complex.

@tbragin
Copy link
Contributor

tbragin commented Aug 4, 2016

Alright - happy to reopen this, as it's lower-hanging fruit. I still like the approach the other issue suggests better.

@tbragin tbragin reopened this Aug 4, 2016
@tbragin tbragin added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Nov 9, 2016
@stacey-gammon
Copy link
Contributor

Closed by #9087

@tbragin tbragin added the v5.2.0 label Jan 6, 2017
jbudz pushed a commit that referenced this issue May 10, 2024
`v94.2.1-backport.0` ⏩ `v94.3.0`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v94.3.0`](https://github.com/elastic/eui/releases/v94.3.0)

- Updated `launch` glyph for `EuiIcon`
([#7670](elastic/eui#7670))
- Updated `EuiComboBox`'s `options` to support including tooltip details
for selectable options. Use `toolTipContent` to render tooltip
information, and `toolTipProps` to optionally customize the tooltip
rendering behavior ([#7700](elastic/eui#7700))
- Updated the following existing glyphs in `EuiIcon`:
([#7727](elastic/eui#7727))
  - `error` (now an outlined version instead of filled) 
  - `tokenMetricCounter`
  - `tokenMetricGauge` 
- Added the following new glyphs to `EuiIcon`:
([#7727](elastic/eui#7727))
  - `tokenDimension`
  - `clickLeft`
  - `clickRight`
  - `clockCounter`
  - `errorFilled` (the previous `error` glyph design)
  - `warningFilled`

**Bug fixes**

- Fixed a visual layout bug for `EuiComboBox` with `isLoading` in mobile
views ([#7700](elastic/eui#7700))
- Fixed missing styles on header cells of `EuiDataGrid` that prevented
content text alignment styles to apply
([#7720](elastic/eui#7720))
- Fixed `EuiFlexGroup` and `EuiFlexItem` `ref` prop typing to support
refs of the same type as the passed `component` type and allow
`displayName` to be defined for easy component naming when using
component wrappers like `styled()`
([#7724](elastic/eui#7724))

---

Most of the code changes you'll see in this PR are caused by the recent
EuiFlex* changes making it generic. This, unfortunately, is something
that `styled()` doesn't always like. I replaced the failing usages of
`styled(EuiFlexGroup)` and `styled(EuiFlexItem)` to use `component` and
other native EuiFlex* props, resulting in the same output but being
better typed.

We plan to add more props to EuiFlex* components giving developers
control over properties like `flex-grow` and `flex-shring`, and reducing
the need for writing any custom CSS when using these components. This
should reduce the number of `styled()` wrappers needed even further

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement v5.2.0
Projects
None yet
Development

No branches or pull requests

6 participants