Elastic Tile Service and configurable leaflet providers #7724

jbudz · 2016-07-12T22:33:06Z

This adds tilemap settings to kibana.yml and changes the default map provider.

epixa · 2016-07-13T00:46:34Z

jenkins, test this

spalger · 2016-07-20T15:33:33Z

LGTM

--------- **Commit 1:** [viz] Allow for configurable map urls * Original sha: 58844a0 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-12T21:29:00Z **Commit 2:** Adds every config option from Leaflet * Original sha: 0b9388c * Authored by Chris Earle <[email protected]> on 2016-07-13T00:31:04Z * Committed by Jonathan Budzenski <[email protected]> on 2016-07-13T01:55:01Z **Commit 3:** Removed confusing config options * Original sha: b1f8ac8 * Authored by Chris Earle <[email protected]> on 2016-07-13T01:07:01Z * Committed by Jonathan Budzenski <[email protected]> on 2016-07-13T01:55:01Z **Commit 4:** [vis] Don't rewrite markdown * Original sha: c670a1c * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T02:52:39Z **Commit 5:** [config] Update default tile link * Original sha: 7c8ec75 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T02:55:16Z **Commit 6:** Change bounds from object to GeoJSON (long, lat) array style * Original sha: 6d8f803 * Authored by Chris Earle <[email protected]> on 2016-07-13T02:58:07Z **Commit 7:** [config] Set max zoom to 7 * Original sha: b762949 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T03:07:47Z **Commit 8:** [tests] Cleanup schema data * Original sha: c3d203f * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T04:04:04Z **Commit 9:** [vis] Bound tilemap zoom * Original sha: 3c1339e * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T15:25:16Z **Commit 10:** Round out support for the initial Elastic Tile Service Correct links, legacy config handling, and wms server conditionals. * Original sha: 41fbb06 * Authored by Court Ewing <[email protected]> on 2016-07-15T20:50:47Z **Commit 11:** Made minZoom in test fixture consistent with reality * Original sha: 6494caa * Authored by Court Ewing <[email protected]> on 2016-07-15T21:11:36Z **Commit 12:** Correctly check for enabled wms to determine zoom Without this defensive check, a JS console error is thrown whenever wms is not configured for a map visualization. * Original sha: c74041c * Authored by Court Ewing <[email protected]> on 2016-07-15T21:15:10Z **Commit 13:** Remove duplicate wms conditional in tilemap createmap This separation made sense in the original implementation, but it is not necessary in this version. * Original sha: ca5a968 * Authored by Court Ewing <[email protected]> on 2016-07-15T21:35:21Z **Commit 14:** Remove optional joi references in tilemap config In joi, configurations are optional by default, so there's no need to be explicit here. * Original sha: 2feac11 * Authored by Court Ewing <[email protected]> on 2016-07-19T17:34:38Z **Commit 15:** Re-disable scroll wheel zoom on maps Enabling scroll wheel search does not seem necessary in the context of this overall bug fix. * Original sha: 2862f94 * Authored by Court Ewing <[email protected]> on 2016-07-19T17:39:40Z

[backport] PR #7724 to 4.x - Elastic Tile Service and configurable leaflet providers

--------- **Commit 1:** [viz] Allow for configurable map urls * Original sha: 58844a0 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-12T21:29:00Z **Commit 2:** Adds every config option from Leaflet * Original sha: 0b9388c * Authored by Chris Earle <[email protected]> on 2016-07-13T00:31:04Z * Committed by Jonathan Budzenski <[email protected]> on 2016-07-13T01:55:01Z **Commit 3:** Removed confusing config options * Original sha: b1f8ac8 * Authored by Chris Earle <[email protected]> on 2016-07-13T01:07:01Z * Committed by Jonathan Budzenski <[email protected]> on 2016-07-13T01:55:01Z **Commit 4:** [vis] Don't rewrite markdown * Original sha: c670a1c * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T02:52:39Z **Commit 5:** [config] Update default tile link * Original sha: 7c8ec75 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T02:55:16Z **Commit 6:** Change bounds from object to GeoJSON (long, lat) array style * Original sha: 6d8f803 * Authored by Chris Earle <[email protected]> on 2016-07-13T02:58:07Z **Commit 7:** [config] Set max zoom to 7 * Original sha: b762949 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T03:07:47Z **Commit 8:** [tests] Cleanup schema data * Original sha: c3d203f * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T04:04:04Z **Commit 9:** [vis] Bound tilemap zoom * Original sha: 3c1339e * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T15:25:16Z **Commit 10:** Round out support for the initial Elastic Tile Service Correct links, legacy config handling, and wms server conditionals. * Original sha: 41fbb06 * Authored by Court Ewing <[email protected]> on 2016-07-15T20:50:47Z **Commit 11:** Made minZoom in test fixture consistent with reality * Original sha: 6494caa * Authored by Court Ewing <[email protected]> on 2016-07-15T21:11:36Z **Commit 12:** Correctly check for enabled wms to determine zoom Without this defensive check, a JS console error is thrown whenever wms is not configured for a map visualization. * Original sha: c74041c * Authored by Court Ewing <[email protected]> on 2016-07-15T21:15:10Z **Commit 13:** Remove duplicate wms conditional in tilemap createmap This separation made sense in the original implementation, but it is not necessary in this version. * Original sha: ca5a968 * Authored by Court Ewing <[email protected]> on 2016-07-15T21:35:21Z **Commit 14:** Remove optional joi references in tilemap config In joi, configurations are optional by default, so there's no need to be explicit here. * Original sha: 2feac11 * Authored by Court Ewing <[email protected]> on 2016-07-19T17:34:38Z **Commit 15:** Re-disable scroll wheel zoom on maps Enabling scroll wheel search does not seem necessary in the context of this overall bug fix. * Original sha: 2862f94 * Authored by Court Ewing <[email protected]> on 2016-07-19T17:39:40Z

[backport] PR #7724 to 4.5 - Elastic Tile Service and configurable leaflet providers

--------- **Commit 1:** [viz] Allow for configurable map urls * Original sha: 58844a0 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-12T21:29:00Z **Commit 2:** Adds every config option from Leaflet * Original sha: 0b9388c * Authored by Chris Earle <[email protected]> on 2016-07-13T00:31:04Z * Committed by Jonathan Budzenski <[email protected]> on 2016-07-13T01:55:01Z **Commit 3:** Removed confusing config options * Original sha: b1f8ac8 * Authored by Chris Earle <[email protected]> on 2016-07-13T01:07:01Z * Committed by Jonathan Budzenski <[email protected]> on 2016-07-13T01:55:01Z **Commit 4:** [vis] Don't rewrite markdown * Original sha: c670a1c * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T02:52:39Z **Commit 5:** [config] Update default tile link * Original sha: 7c8ec75 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T02:55:16Z **Commit 6:** Change bounds from object to GeoJSON (long, lat) array style * Original sha: 6d8f803 * Authored by Chris Earle <[email protected]> on 2016-07-13T02:58:07Z **Commit 7:** [config] Set max zoom to 7 * Original sha: b762949 * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T03:07:47Z **Commit 8:** [tests] Cleanup schema data * Original sha: c3d203f * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T04:04:04Z **Commit 9:** [vis] Bound tilemap zoom * Original sha: 3c1339e * Authored by Jonathan Budzenski <[email protected]> on 2016-07-13T15:25:16Z **Commit 10:** Round out support for the initial Elastic Tile Service Correct links, legacy config handling, and wms server conditionals. * Original sha: 41fbb06 * Authored by Court Ewing <[email protected]> on 2016-07-15T20:50:47Z **Commit 11:** Made minZoom in test fixture consistent with reality * Original sha: 6494caa * Authored by Court Ewing <[email protected]> on 2016-07-15T21:11:36Z **Commit 12:** Correctly check for enabled wms to determine zoom Without this defensive check, a JS console error is thrown whenever wms is not configured for a map visualization. * Original sha: c74041c * Authored by Court Ewing <[email protected]> on 2016-07-15T21:15:10Z **Commit 13:** Remove duplicate wms conditional in tilemap createmap This separation made sense in the original implementation, but it is not necessary in this version. * Original sha: ca5a968 * Authored by Court Ewing <[email protected]> on 2016-07-15T21:35:21Z **Commit 14:** Remove optional joi references in tilemap config In joi, configurations are optional by default, so there's no need to be explicit here. * Original sha: 2feac11 * Authored by Court Ewing <[email protected]> on 2016-07-19T17:34:38Z **Commit 15:** Re-disable scroll wheel zoom on maps Enabling scroll wheel search does not seem necessary in the context of this overall bug fix. * Original sha: 2862f94 * Authored by Court Ewing <[email protected]> on 2016-07-19T17:39:40Z ------------------------------- **Backported based on diff from PR #7779**

Elastic Tile Service and configurable leaflet providers Former-commit-id: bb7cdc9

`v94.2.1-backport.0` ⏩ `v94.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v94.3.0`](https://github.com/elastic/eui/releases/v94.3.0) - Updated `launch` glyph for `EuiIcon` ([#7670](elastic/eui#7670)) - Updated `EuiComboBox`'s `options` to support including tooltip details for selectable options. Use `toolTipContent` to render tooltip information, and `toolTipProps` to optionally customize the tooltip rendering behavior ([#7700](elastic/eui#7700)) - Updated the following existing glyphs in `EuiIcon`: ([#7727](elastic/eui#7727)) - `error` (now an outlined version instead of filled) - `tokenMetricCounter` - `tokenMetricGauge` - Added the following new glyphs to `EuiIcon`: ([#7727](elastic/eui#7727)) - `tokenDimension` - `clickLeft` - `clickRight` - `clockCounter` - `errorFilled` (the previous `error` glyph design) - `warningFilled` **Bug fixes** - Fixed a visual layout bug for `EuiComboBox` with `isLoading` in mobile views ([#7700](elastic/eui#7700)) - Fixed missing styles on header cells of `EuiDataGrid` that prevented content text alignment styles to apply ([#7720](elastic/eui#7720)) - Fixed `EuiFlexGroup` and `EuiFlexItem` `ref` prop typing to support refs of the same type as the passed `component` type and allow `displayName` to be defined for easy component naming when using component wrappers like `styled()` ([#7724](elastic/eui#7724)) --- Most of the code changes you'll see in this PR are caused by the recent EuiFlex* changes making it generic. This, unfortunately, is something that `styled()` doesn't always like. I replaced the failing usages of `styled(EuiFlexGroup)` and `styled(EuiFlexItem)` to use `component` and other native EuiFlex* props, resulting in the same output but being better typed. We plan to add more props to EuiFlex* components giving developers control over properties like `flex-grow` and `flex-shring`, and reducing the need for writing any custom CSS when using these components. This should reduce the number of `styled()` wrappers needed even further --------- Co-authored-by: kibanamachine <[email protected]>

jbudz added blocker review blocked v5.0.0-beta1 labels Jul 12, 2016

jbudz force-pushed the server-map-url branch from 19f00ac to 2ede701 Compare July 12, 2016 22:34

jbudz added v4.6.0 v4.1.10 v4.5.3 labels Jul 12, 2016

jbudz force-pushed the server-map-url branch 3 times, most recently from 01c2a6d to 4a5b0d3 Compare July 12, 2016 23:06

jbudz added a commit to jbudz/kibana that referenced this pull request Jul 13, 2016

[backport] PR elastic#7724 to 4.1

70aab84

jbudz and others added 4 commits July 12, 2016 21:55

[viz] Allow for configurable map urls

58844a0

Adds every config option from Leaflet

0b9388c

Removed confusing config options

b1f8ac8

[vis] Don't rewrite markdown

c670a1c

jbudz force-pushed the server-map-url branch from a272667 to c670a1c Compare July 13, 2016 02:52

jbudz and others added 3 commits July 12, 2016 22:55

[config] Update default tile link

7c8ec75

Change bounds from object to GeoJSON (long, lat) array style

6d8f803

[config] Set max zoom to 7

b762949

epixa mentioned this pull request Jul 13, 2016

[backport] PR #7724 to 4.1 - New tile map service #7727

Closed

epixa pushed a commit that referenced this pull request Jul 13, 2016

[backport] PR #7724 to 4.1

38aceef

Bargs removed their assignment Jul 20, 2016

epixa assigned spalger and unassigned jbudz Jul 20, 2016

epixa added v5.0.0-alpha5 and removed v5.0.0-beta1 labels Jul 20, 2016

spalger removed their assignment Jul 20, 2016

epixa merged commit bb7cdc9 into elastic:master Jul 20, 2016

epixa deleted the server-map-url branch July 20, 2016 15:35

elastic-jasper mentioned this pull request Jul 20, 2016

[backport] PR #7724 to 4.x - Elastic Tile Service and configurable leaflet providers #7779

Merged

epixa mentioned this pull request Jul 20, 2016

Add default map-tiles provider to configuration file #7050

Closed

epixa added a commit that referenced this pull request Jul 21, 2016

Merge pull request #7779 from elastic/jasper/backport/7724/4.x

ad36332

[backport] PR #7724 to 4.x - Elastic Tile Service and configurable leaflet providers

elastic-jasper mentioned this pull request Jul 21, 2016

[backport] PR #7724 to 4.5 - Elastic Tile Service and configurable leaflet providers #7790

Merged

epixa added a commit that referenced this pull request Jul 21, 2016

Merge pull request #7790 from elastic/jasper/backport/7724/7779/4.5

ac822f1

[backport] PR #7724 to 4.5 - Elastic Tile Service and configurable leaflet providers

elastic-jasper mentioned this pull request Jul 21, 2016

[backport] PR #7724 to 4.3 #7798

Closed

elastic-jasper mentioned this pull request Jul 21, 2016

[backport] PR #7724 to 4.3 #7799

Closed

epixa added v5.0.0 and removed v5.0.0 labels Aug 1, 2016

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017

Merge pull request elastic#7724 from jbudz/server-map-url

6f30c77

Elastic Tile Service and configurable leaflet providers Former-commit-id: bb7cdc9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Elastic Tile Service and configurable leaflet providers #7724

Elastic Tile Service and configurable leaflet providers #7724

jbudz commented Jul 12, 2016 •

edited by epixa

Loading

epixa commented Jul 13, 2016

spalger commented Jul 20, 2016

Elastic Tile Service and configurable leaflet providers #7724

Elastic Tile Service and configurable leaflet providers #7724

Conversation

jbudz commented Jul 12, 2016 • edited by epixa Loading

epixa commented Jul 13, 2016

spalger commented Jul 20, 2016

jbudz commented Jul 12, 2016 •

edited by epixa

Loading