Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Redesign launch glyph #7670

Merged
merged 4 commits into from
Apr 30, 2024
Merged

[EuiIcon] Redesign launch glyph #7670

merged 4 commits into from
Apr 30, 2024

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Apr 10, 2024

Summary

Redesign the launch glyph for Serena and Catherine.
Figma branch

Before (light and dark mode)

CleanShot 2024-04-10 at 15 02 18@2x
CleanShot 2024-04-10 at 15 02 28@2x

After (light and dark mode)

CleanShot 2024-04-29 at 19 17 31@2x
CleanShot 2024-04-29 at 19 17 42@2x

Check for spacing/sizing

CleanShot 2024-04-29 at 19 18 31@2x

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • Updated the Figma library counterpart

@ryankeairns ryankeairns marked this pull request as ready for review April 10, 2024 22:14
@ryankeairns ryankeairns requested a review from a team as a code owner April 10, 2024 22:14
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

denied because this ryan guy is supposed to be on PTO so clearly this must be an AI copy of him

@ryankeairns
Copy link
Contributor Author

😆 I was waiting at a coffee shop for mi familia. Point taken!

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryankeairns: The changes look very nice. Would it be possible to adjust the rocket's fins and exhaust trail slightly so that they align better to the pixel grid? Otherwise, once that is addressed and the Figma library is updated, this is good to go from my perspective.

CleanShot 2024-04-15 at 13 55 07

@ryankeairns
Copy link
Contributor Author

ryankeairns commented Apr 17, 2024

@ryankeairns: The changes look very nice. Would it be possible to adjust the rocket's fins and exhaust trail slightly so that they align better to the pixel grid? Otherwise, once that is addressed and the Figma library is updated, this is good to go from my perspective.

In hindsight, designing it then rotating the entire thing may not have been the best approach. I'll give it another go and build it at 45 deg angle, from the start, and see if I can get it tighter.

@cee-chen
Copy link
Contributor

Moving this back to draft while it's still in progress!

@cee-chen cee-chen marked this pull request as draft April 17, 2024 17:02
@cee-chen cee-chen changed the title Redesign launch glyph [EuiIcon] Redesign launch glyph Apr 17, 2024
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@ryankeairns ryankeairns marked this pull request as ready for review April 30, 2024 03:44
@ryankeairns
Copy link
Contributor Author

The rocket rides again!

Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@ryankeairns ryankeairns merged commit 907a47b into main Apr 30, 2024
8 checks passed
@ryankeairns ryankeairns deleted the rk/launchlaunch branch April 30, 2024 17:00
@serenachou
Copy link

@ryankeairns I have never felt more appreciated. You've brought a tear of joy to my face today!!!!!!!!!

@julianrosado
Copy link

Boooooo

mgadewoll pushed a commit to mgadewoll/eui that referenced this pull request May 3, 2024
jbudz pushed a commit to elastic/kibana that referenced this pull request May 10, 2024
`v94.2.1-backport.0` ⏩ `v94.3.0`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v94.3.0`](https://github.com/elastic/eui/releases/v94.3.0)

- Updated `launch` glyph for `EuiIcon`
([#7670](elastic/eui#7670))
- Updated `EuiComboBox`'s `options` to support including tooltip details
for selectable options. Use `toolTipContent` to render tooltip
information, and `toolTipProps` to optionally customize the tooltip
rendering behavior ([#7700](elastic/eui#7700))
- Updated the following existing glyphs in `EuiIcon`:
([#7727](elastic/eui#7727))
  - `error` (now an outlined version instead of filled) 
  - `tokenMetricCounter`
  - `tokenMetricGauge` 
- Added the following new glyphs to `EuiIcon`:
([#7727](elastic/eui#7727))
  - `tokenDimension`
  - `clickLeft`
  - `clickRight`
  - `clockCounter`
  - `errorFilled` (the previous `error` glyph design)
  - `warningFilled`

**Bug fixes**

- Fixed a visual layout bug for `EuiComboBox` with `isLoading` in mobile
views ([#7700](elastic/eui#7700))
- Fixed missing styles on header cells of `EuiDataGrid` that prevented
content text alignment styles to apply
([#7720](elastic/eui#7720))
- Fixed `EuiFlexGroup` and `EuiFlexItem` `ref` prop typing to support
refs of the same type as the passed `component` type and allow
`displayName` to be defined for easy component naming when using
component wrappers like `styled()`
([#7724](elastic/eui#7724))

---

Most of the code changes you'll see in this PR are caused by the recent
EuiFlex* changes making it generic. This, unfortunately, is something
that `styled()` doesn't always like. I replaced the failing usages of
`styled(EuiFlexGroup)` and `styled(EuiFlexItem)` to use `component` and
other native EuiFlex* props, resulting in the same output but being
better typed.

We plan to add more props to EuiFlex* components giving developers
control over properties like `flex-grow` and `flex-shring`, and reducing
the need for writing any custom CSS when using these components. This
should reduce the number of `styled()` wrappers needed even further

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants