Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Allow data view editing without switching the management #144801

Closed
kertal opened this issue Nov 8, 2022 · 1 comment · Fixed by #149453
Closed

[Discover] Allow data view editing without switching the management #144801

kertal opened this issue Nov 8, 2022 · 1 comment · Fixed by #149453
Assignees
@mattkime
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Nov 8, 2022 •
edited
Loading

Once we have #144149 merged, we can implement editing data views without going to Stack management. This was implemented in #142723 for Lens, and with the new internal state container in place, it can be done in Discover. This will improve the editing step especially for ad-hoc data view significantly.
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Nov 8, 2022
@davismcphee davismcphee added the enhancement New value added to drive a business result label Nov 8, 2022
@petrklapka petrklapka added the Feature:Search Querying infrastructure in Kibana label Nov 21, 2022
@kertal kertal mentioned this issue Nov 22, 2022
Closed
2 tasks
@dimaanj dimaanj mentioned this issue Dec 6, 2022
Closed
1 task
@dimaanj dimaanj mentioned this issue Dec 19, 2022
Closed
1 task
@dimaanj dimaanj mentioned this issue Jan 3, 2023
Closed
1 task
@dimaanj dimaanj removed their assignment Jan 4, 2023
@kertal kertal added Feature:Data Views Data Views code and UI - index patterns before 8.0 and removed Feature:Search Querying infrastructure in Kibana labels Jan 9, 2023
@mattkime mattkime mentioned this issue Jan 24, 2023
Merged
1 task
mattkime added a commit that referenced this issue Jan 30, 2023
@mattkime @kertal @kibanamachine
[discover] Enable data view editing from flyout (#149453)
a64027d 
## Summary

Currently, changes to a data view require a round trip to management
when you're in discover. This PR allows editing of data views via flyout
from within discover.

Closes #144801


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Matthias Wilhelm <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Feb 6, 2023
@mattkime @kertal
@kibanamachine @kqualters-elastic
[discover] Enable data view editing from flyout (elastic#149453)
9697e20 
## Summary

Currently, changes to a data view require a round trip to management
when you're in discover. This PR allows editing of data views via flyout
from within discover.

Closes elastic#144801


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Matthias Wilhelm <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
6 participants
@mattkime @kertal @elasticmachine @davismcphee @dimaanj @petrklapka