Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Enable data view editing from flyout #148283

Closed
wants to merge 11 commits into from
Closed

[Discover] Enable data view editing from flyout #148283

wants to merge 11 commits into from

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Jan 3, 2023

Summary

Closes #144801

This PR enables data view edit from flyout for all data views

Checklist

@dimaanj dimaanj added release_note:enhancement Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0 labels Jan 3, 2023
@dimaanj dimaanj self-assigned this Jan 3, 2023
@dimaanj dimaanj mentioned this pull request Jan 3, 2023
Closed
1 task
@dimaanj
Merge branch 'main' of https://github.com/elastic/kibana into enable-…
de413bd 
…data-view-edit-from-flyout-1

# Conflicts:
#	src/plugins/discover/public/application/main/components/top_nav/discover_topnav.tsx
@dimaanj
Copy link
Contributor Author

dimaanj commented Jan 4, 2023

@elasticmachine merge upstream

@dimaanj dimaanj marked this pull request as ready for review January 4, 2023 07:15
@dimaanj dimaanj requested a review from a team as a code owner January 4, 2023 07:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@dimaanj
Copy link
Contributor Author

dimaanj commented Jan 4, 2023

@elasticmachine merge upstream

@dimaanj
Copy link
Contributor Author

dimaanj commented Jan 4, 2023

@elasticmachine merge upstream

@mattkime
Copy link
Contributor

mattkime commented Jan 9, 2023 •
edited
Loading

I created the sample data sets and selected the kibana ecommerce data view. Then I edited it so the index pattern was kibana-* - the field list updates but the type icons are incorrect. As best I can tell, the rest looks fine.

@kertal
Copy link
Member

kertal commented Jan 9, 2023

@elasticmachine merge upstream

kertal
kertal reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@kertal kertal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dear @mattkime, could you investigate, I don't think this works correctly, also IMO there should be a functional test.
When I changed the index pattern of a data view this happened when I tested
Discover_-_Elastic

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 9, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #53 / kibana server with ssl handles requests using ssl with a P12 keystore that uses an intermediate CA
  • [job] [logs] FTR Configs #53 / kibana server with ssl handles requests using ssl with a P12 keystore that uses an intermediate CA

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 395.9KB 396.1KB +207.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

@kertal kertal requested a review from mattkime January 11, 2023 17:47
@kertal kertal assigned mattkime and unassigned dimaanj Jan 11, 2023
@davismcphee
Copy link
Contributor

Closing in favour of #149453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal left review comments

@mattkime mattkime Awaiting requested review from mattkime

Assignees

@mattkime mattkime

Labels
Feature:Discover Discover Application release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Allow data view editing without switching the management
7 participants
@dimaanj @elasticmachine @mattkime @kertal @kibana-ci @davismcphee @kibanamachine