Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Enable Data View edit from flyout #147111

Closed
wants to merge 2 commits into from
Closed

[Discover] Enable Data View edit from flyout #147111

wants to merge 2 commits into from

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Dec 6, 2022

Summary

Closes #144801

This PR enables data view edit from flyout for all data views

Checklist

@dimaanj dimaanj added release_note:enhancement Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0 labels Dec 6, 2022
@dimaanj dimaanj self-assigned this Dec 6, 2022
@dimaanj
Merge branch 'main' of https://github.com/elastic/kibana into enable-…
ce8c17a 
…data-view-editing-from-flyout

# Conflicts:
#	src/plugins/discover/public/application/main/discover_main_app.tsx
#	src/plugins/discover/public/application/main/hooks/use_discover_state.ts
@kibana-ci
Copy link
Collaborator

kibana-ci commented Dec 14, 2022 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/functional_basic/config.ts / apps machine learning basic license data visualizer field statistics in Discover when enabled with KQL saved search and filters displays the 'Field statistics' table content correctly
  • [job] [logs] x-pack/test/functional_basic/config.ts / apps machine learning basic license data visualizer field statistics in Discover when enabled with KQL saved search and filters displays the 'Field statistics' table content correctly
  • [job] [logs] x-pack/test/functional_basic/config.ts / apps machine learning basic license data visualizer field statistics in Discover when enabled with KQL saved search displays the 'Field statistics' table content correctly
  • [job] [logs] x-pack/test/functional_basic/config.ts / apps machine learning basic license data visualizer field statistics in Discover when enabled with KQL saved search displays the 'Field statistics' table content correctly
  • [job] [logs] x-pack/test/functional_basic/config.ts / apps machine learning basic license data visualizer field statistics in Discover when enabled with lucene saved search and filter displays the 'Field statistics' table content correctly
  • [job] [logs] x-pack/test/functional_basic/config.ts / apps machine learning basic license data visualizer field statistics in Discover when enabled with lucene saved search and filter displays the 'Field statistics' table content correctly
  • [job] [logs] x-pack/test/functional_basic/config.ts / apps machine learning basic license data visualizer field statistics in Discover when enabled with lucene saved search displays the 'Field statistics' table content correctly
  • [job] [logs] x-pack/test/functional_basic/config.ts / apps machine learning basic license data visualizer field statistics in Discover when enabled with lucene saved search displays the 'Field statistics' table content correctly
  • [job] [logs] FTR Configs #38 / discover Discover CSV Export Generate CSV: sparse data "before each" hook for "handles field formatting for a field that doesn't exist initially"
  • [job] [logs] FTR Configs #38 / discover Discover CSV Export Generate CSV: sparse data "before each" hook for "handles field formatting for a field that doesn't exist initially"
  • [job] [logs] FTR Configs #14 / discover/ccs_compatible discover integration with data view editor allows edit adhoc data view from flyout
  • [job] [logs] FTR Configs #21 / discover/ccs_compatible discover integration with data view editor allows edit adhoc data view from flyout
  • [job] [logs] FTR Configs #21 / discover/ccs_compatible discover integration with data view editor allows edit adhoc data view from flyout
  • [job] [logs] FTR Configs #14 / discover/ccs_compatible discover integration with data view editor allows edit adhoc data view from flyout
  • [job] [logs] FTR Configs #14 / discover/ccs_compatible discover integration with data view editor allows edit data view from flyout
  • [job] [logs] FTR Configs #14 / discover/ccs_compatible discover integration with data view editor allows edit data view from flyout
  • [job] [logs] FTR Configs #24 / machine learning - data visualizer field statistics in Discover when enabled with KQL saved search and filters displays the 'Field statistics' table content correctly
  • [job] [logs] FTR Configs #24 / machine learning - data visualizer field statistics in Discover when enabled with KQL saved search and filters displays the 'Field statistics' table content correctly
  • [job] [logs] FTR Configs #24 / machine learning - data visualizer field statistics in Discover when enabled with KQL saved search displays the 'Field statistics' table content correctly
  • [job] [logs] FTR Configs #24 / machine learning - data visualizer field statistics in Discover when enabled with KQL saved search displays the 'Field statistics' table content correctly
  • [job] [logs] FTR Configs #24 / machine learning - data visualizer field statistics in Discover when enabled with lucene saved search and filter displays the 'Field statistics' table content correctly
  • [job] [logs] FTR Configs #24 / machine learning - data visualizer field statistics in Discover when enabled with lucene saved search and filter displays the 'Field statistics' table content correctly
  • [job] [logs] FTR Configs #24 / machine learning - data visualizer field statistics in Discover when enabled with lucene saved search displays the 'Field statistics' table content correctly
  • [job] [logs] FTR Configs #24 / machine learning - data visualizer field statistics in Discover when enabled with lucene saved search displays the 'Field statistics' table content correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 418.4KB 418.6KB +257.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 60 66 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

@dimaanj
Copy link
Contributor Author

dimaanj commented Dec 19, 2022

Closing, since #147772 created

@dimaanj dimaanj closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dimaanj dimaanj

Labels
Feature:Discover Discover Application release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Allow data view editing without switching the management
2 participants
@dimaanj @kibana-ci