[UnifiedSearch] Allow editing ad-hoc data views without permissions #142723
Conversation
flash1293
added
release_note:enhancement
Feature:Discover
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
|
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
@flash1293 one question! I have created the I assume that the default time field has been selected for this, which must be the order_date. When I click the Manage button, the flyout opens with the timestamp field dropdown as disabled (and the order_date not selected). If I want to change the time field I have to make a change in the pattern. Is this what we want?
|
|
@stratoula this is a bug in the data view editor at the moment - on opening it doesn't compute matching indices right, that's why it's disabled. If you change the pattern, then change it back to the original one it becomes enabled. @mattkime is working on fixing this on another PR. |
|
There is one more place in Discover where we allow field editing: column dropdown
Would be great to update it too. |
|
Good catch @jughosta , added the updated condition there as well. |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
| defaultMessage: 'Manage this data view', | ||
| })} | ||
| </EuiContextMenuItem>, | ||
| onEditDataView || dataViewEditor.userPermissions.editDataView() ? ( |
There was a problem hiding this comment.
readabiily nit: move this outside this .push and add a separate if check
kibanamachine
added
v8.6.0
backport:skip
…lastic#142723) * allow editing ad-hoc data views without permissions * [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs' * fxi tests * fix test * allow field editing from discover table Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
…lastic#142723) * allow editing ad-hoc data views without permissions * [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs' * fxi tests * fix test * allow field editing from discover table Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
Part of #141806
Allows to add/remove/edit fields for ad hoc data views in Discover and Lens, as well as "managing" ad hoc data views (changing pattern, default time field) in Lens.