Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Add internal state container #144816

Closed
kertal opened this issue Nov 8, 2022 · 2 comments
Closed

[Discover] Add internal state container #144816

kertal opened this issue Nov 8, 2022 · 2 comments
Labels
chore Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Nov 8, 2022

Part of #140765

Summary

We need to introduce a new state container for the internal state, that's the state used in several components but not synced with the URL (While appState and globalState are synced with the URL). This new container would contain 2 values: dataView & dataViewAdHocList, which are used in several parts of Discover

export interface InternalState {
   dataView: DataView | undefined;
   dataViewAdHocList: DataView[];
 }

This new state container would be part of DiscoverStateContainer (formerly known as GetStateReturn), preparing for the consolidation of various state-related code in a central container drafted in #140765.

This PR allows us to move forward to enable editing of data views directly in Discover like Lens #142723

@kertal kertal added chore Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the loe:medium Medium Level of Effort label Nov 8, 2022
@kertal kertal added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Nov 8, 2022
@kertal
Copy link
Member Author

kertal commented Dec 22, 2022

closing in favor of #145074

@kertal kertal closed this as completed Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

2 participants