Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: X-Pack Reporting Functional Tests: Reports and Timeout Handling.x-pack/test/reporting_functional/reporting_and_timeout - Reporting Functional Tests with forced timeout adds a visual warning in the report output #135309

Closed
kibanamachine opened this issue Jun 28, 2022 · 17 comments · Fixed by #135356, #136483, #144580 or #164383
Assignees
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead failed-test A test failure on a tracked branch, potentially flaky-test Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 28, 2022

A test failed on a tracked branch

Error: expected 0.01084983087942698 to be below 0.01
    at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.lessThan.Assertion.below (node_modules/@kbn/expect/expect.js:336:8)
    at Function.lessThan (node_modules/@kbn/expect/expect.js:531:15)
    at Context.<anonymous> (x-pack/test/reporting_functional/reporting_and_timeout/index.ts:53:92)
    at Object.apply (node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

First failure: CI Build - main

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jun 28, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 28, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@tsullivan
Copy link
Member

Looking to see if the "session" image that was generated at test time can be retrieved

@tsullivan
Copy link
Member

The session image didn't match, because the "loading" indicators weren't on the screen. Therefore, in this case it is appropriate to increase the allowance for visual differences in the test.

Session image:
image

Baseline image:
image

@tsullivan
Copy link
Member

PR fix: #135356

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@spalger
Copy link
Contributor

spalger commented Jun 29, 2022

14 failures in the last week, I appreciate that you're close with #135356 @tsullivan but I'm going to skip until it's done. Please make sure to unskip in your PR after merging main.

image

@spalger spalger closed this as completed Jun 29, 2022
@spalger spalger reopened this Jun 29, 2022
spalger pushed a commit that referenced this issue Jun 29, 2022
tsullivan added a commit to tsullivan/kibana that referenced this issue Jun 29, 2022
tsullivan added a commit that referenced this issue Jun 29, 2022
#135356)

* [reporting] functional test: increase allowance for visual difference in downloaded report

* Revert "skip flaky suite (#135309)"

This reverts commit b556857.

Co-authored-by: Kibana Machine <[email protected]>
yakhinvadim pushed a commit to yakhinvadim/kibana that referenced this issue Jul 5, 2022
yakhinvadim pushed a commit to yakhinvadim/kibana that referenced this issue Jul 5, 2022
elastic#135356)

* [reporting] functional test: increase allowance for visual difference in downloaded report

* Revert "skip flaky suite (elastic#135309)"

This reverts commit b556857.

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine reopened this Jul 15, 2022
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@tsullivan
Copy link
Member

I'm sending up a new PR to add more allowance to the visual difference, to unblock further flaky failures.

baseline image:
warnings_capture_a_baseline

actual image that caused the failure:
warnings_capture_session_a_actual

the part needed for test validation is just the warning message at the top. If further flakiness happens then a good solution would be to crop the image area to the important part before the image comparison.

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@mistic
Copy link
Member

mistic commented Oct 5, 2022

Skipped.

main: 0a03a52

WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this issue Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this issue Oct 14, 2022
@petrklapka petrklapka added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Reporting Services labels Oct 24, 2022
@tsullivan tsullivan self-assigned this Nov 3, 2022
@kibanamachine kibanamachine reopened this Nov 9, 2022
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jbudz
Copy link
Member

jbudz commented Nov 10, 2022

/skip

@jbudz
Copy link
Member

jbudz commented Nov 10, 2022

Skipped

main: 37c23b4

@tsullivan
Copy link
Member

The latest failures look like a new type of error, which is probably a regression from the last round of maintenance:



2022-11-10 07:52:23 MST | └-: Reporting Functional Tests with forced timeout
-- | --
  | 2022-11-10 07:52:23 MST | └-> "before all" hook: beforeTestSuite.trigger for "adds a visual warning in the report output"
  | 2022-11-10 07:52:23 MST | └-> "before all" hook for "adds a visual warning in the report output"
  | 2022-11-10 07:52:23 MST | └-> adds a visual warning in the report output
  | 2022-11-10 07:53:04 MST | └-> "before each" hook: global before each for "adds a visual warning in the report output"
  | 2022-11-10 07:53:04 MST | └- ✖ fail: Reporting Functional Tests with forced timeout adds a visual warning in the report output
  | 2022-11-10 07:53:04 MST | │      Error: Unrecognised filter type - 196
  | 2022-11-10 07:53:04 MST | │       at module.exports.Filter._reverseFilterLine (node_modules/pngjs/lib/filter-parse.js:147:15)
  | 2022-11-10 07:53:04 MST | │       at module.exports.SyncReader.process (node_modules/pngjs/lib/sync-reader.js:34:17)
  | 2022-11-10 07:53:04 MST | │       at Object.exports.process (node_modules/pngjs/lib/filter-parse-sync.js:21:10)
  | 2022-11-10 07:53:04 MST | │       at module.exports (node_modules/pngjs/lib/parser-sync.js:93:35)
  | 2022-11-10 07:53:04 MST | │       at Object.read (node_modules/pngjs/lib/png-sync.js:10:10)
  | 2022-11-10 07:53:04 MST | │       at comparePngs (test/functional/services/lib/compare_pngs.ts:106:35)
  | 2022-11-10 07:53:04 MST | │       at PngService.comparePngs (test/functional/services/common/png.ts:32:12)
  | 2022-11-10 07:53:04 MST | │       at PngService.checkIfPngsMatch (test/functional/services/common/png.ts:69:18)
  | 2022-11-10 07:53:04 MST | │       at Context.<anonymous> (x-pack/test/reporting_functional/reporting_and_timeout/index.ts:82:9)
  | 2022-11-10 07:53:04 MST | │       at Object.apply (node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:78:16)
  | 2022-11-10 07:53:04 MST | │
  | 2022-11-10 07:53:04 MST | │


@petrklapka
Copy link
Member

@tsullivan - Can you please set an LOE estimate? Thanks!

tsullivan added a commit that referenced this issue Aug 22, 2023
## Summary

Closes #135309

This PR eliminates a skipped functional test by replacing the test
coverage with unit tests.

*
`x-pack/plugins/screenshotting/server/screenshots/screenshots.test.ts`:
ensures that waiting too long for the URL to open will return the
expected error message
*
`x-pack/plugins/screenshotting/server/browsers/chromium/driver.test.ts`:
ensures that when the screenshot capture method is passed an error
message, that error message is injected into the screenshot

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead failed-test A test failure on a tracked branch, potentially flaky-test Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
7 participants