Reporting/fix visual warning test #164383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
commented
Aug 22, 2023
| @@ -6,6 +6,7 @@ | |||
| */ | |||
|
|
|||
| import type { Logger } from '@kbn/core/server'; | |||
| import { loggerMock } from '@kbn/logging-mocks'; | |||
There was a problem hiding this comment.
There aren't any changes made to this file except for some minor cleanups
tsullivan
commented
Aug 22, 2023
| timeRange: null, | ||
| }; | ||
|
|
||
| export class Screenshots { |
There was a problem hiding this comment.
moved this class to a standalone file
tsullivan
commented
Aug 22, 2023
| timeRange: null, | ||
| }; | ||
|
|
||
| export class Screenshots { |
There was a problem hiding this comment.
Moved this out from index.ts
tsullivan
added
test
release_note:skip
rshen91
approved these changes
Aug 22, 2023
tsullivan
commented
Aug 22, 2023
| @@ -347,7 +347,6 @@ enabled: | |||
| - x-pack/test/reporting_functional/reporting_and_deprecated_security.config.ts | |||
| - x-pack/test/reporting_functional/reporting_and_security.config.ts | |||
| - x-pack/test/reporting_functional/reporting_without_security.config.ts | |||
| - x-pack/test/reporting_functional/reporting_and_timeout.config.ts | |||
There was a problem hiding this comment.
Note: added in 124a76c
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
delanni
approved these changes
Aug 22, 2023
kibanamachine
added
v8.11.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #135309
This PR eliminates a skipped functional test by replacing the test coverage with unit tests.
x-pack/plugins/screenshotting/server/screenshots/screenshots.test.ts: ensures that waiting too long for the URL to open will return the expected error messagex-pack/plugins/screenshotting/server/browsers/chromium/driver.test.ts: ensures that when the screenshot capture method is passed an error message, that error message is injected into the screenshot