Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Unskip screenshotting timeouts test #144580

Merged
merged 5 commits into from
Nov 9, 2022
Merged

[Reporting] Unskip screenshotting timeouts test #144580

merged 5 commits into from
Nov 9, 2022

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Nov 4, 2022 •
edited
Loading

@tsullivan tsullivan changed the title Unskip flaky reporting test suite [Reporting] Unskip screenshotting timeouts test Nov 4, 2022
@tsullivan tsullivan marked this pull request as ready for review November 8, 2022 23:27
@tsullivan tsullivan requested a review from a team as a code owner November 8, 2022 23:27
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Nov 8, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens
jloleysens approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for the clear comments!

@tsullivan tsullivan merged commit 192068d into elastic:main Nov 9, 2022
@tsullivan tsullivan deleted the fix/issues/135309 branch November 9, 2022 16:54
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Nov 9, 2022
@tsullivan tsullivan mentioned this pull request Nov 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.6.0
Projects
None yet
Milestone
No milestone
4 participants
@tsullivan @kibana-ci @jloleysens @kibanamachine