Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reporting] functional test: increase allowance for visual difference… #135356

Merged
merged 8 commits into from
Jun 29, 2022
Merged

[reporting] functional test: increase allowance for visual difference… #135356

merged 8 commits into from
Jun 29, 2022

Conversation

tsullivan
Copy link
Member

Closes #135309

@tsullivan tsullivan requested review from a team as code owners June 28, 2022 18:47
@tsullivan tsullivan mentioned this pull request Jun 28, 2022
Closed
@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:AppServicesUx v8.4.0 labels Jun 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

mattkime
mattkime approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 0611f5d into elastic:main Jun 29, 2022
@tsullivan tsullivan deleted the reporting/test-fn-warning-image branch June 29, 2022 20:49
yakhinvadim pushed a commit to yakhinvadim/kibana that referenced this pull request Jul 5, 2022
@tsullivan @kibanamachine
[reporting] functional test: increase allowance for visual difference… (
2866738 
elastic#135356)

* [reporting] functional test: increase allowance for visual difference in downloaded report

* Revert "skip flaky suite (elastic#135309)"

This reverts commit b556857.

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Milestone
No milestone
5 participants
@tsullivan @elasticmachine @kibana-ci @mattkime @kibanamachine