-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Playground / Toggle System for Live Documentation #3057
Comments
@anishagg17 We'll use this issue to discuss and track modifications to your proposal. Comment in this thread and then I can assign the issue to you. |
@thompsongl Sorry for the late reply , I think my
Sure this would be great! |
@cchaos We'll use this issue to track discussion for the EUI docs project. Post anything you've been thinking about for design, etc. I'll be updating the main summary area soon |
My current thoughts are that I'd like to avoid creating a new tab to each documentation section. Instead, I'm thinking that it's basically a separate page(application) with all the components listed in it's own side nav on the left and toggles/code editor on the right. Then each component in our normal docs would just have a button/link that goes to it's playground section in this new page/app. I'll probably think through the design/layout of this over the next month, but that's the basic idea. |
@anishagg17 You can start exploring this idea. I'll do some research, as well.
|
Before coding , let's discuss several alternatives that can be used for this purpose
Also ,
Inculcates creating a new section within the docs-site this would be the first step later we can use the library of our choice and utilise it |
react-livePros
Cons
|
react-viewPros
Cons
|
|
Yes, that might be made possible with some modifications, checks. @cchaos Can you add more clarity to the app do we need separate playground for |
No there would be a single playground for each component, not docs example. So a single playground for EuiButton with toggles based on all the possible props. |
@thompsongl these are the props definition rendered by doc-gen (only some props are mentioned for simplicity)
And these are the prop definition required by the react-view component.
|
The similarities look promising. |
@thompsongl This will be the output from the parser. It seems like it is similar to what required by |
That's great; thank you. @anishagg17 what about using EUI components inside |
Can we have the roadmap for the first month? |
This is awesome, @anishagg17 @cchaos What do you think about this concept? |
This is definitely very similar to the UI explorations I'm currently working on. The only concern I have is looking at the code, it seems very manual to create the "toggle" parts. I was hoping we could utilize more of the |
I don't think we would create many toggles as the working would proceed with
|
Let's try this for
Start with Layout components, then Utilities |
@cchaos does |
No, we can skip that one |
@thompsongl #3959 marks the completion of all playgrounds 🎉 . Anything more that I need to do? |
@anishagg17 Thank you so much for all the work you did on this project!!! 🎉 🎉 It's amazing what's been accomplished over this past summer. The playground toggles really step up our documentation game and gives us such an easier way to test all the permutations of each component. Best of luck to you in future endeavors! |
@anishagg17 Nothing more as far as EUI is concerned 😄 Just make sure you submit all your GSoC evaluations, etc. before the deadline later this week (if you haven't already). You've done great work and should be proud of the last few months! I know all of us here were glad to have you and are thrilled with the outcome 🚀 |
Closing this because @anishagg17 did all the things We'll track anything related to component playground in the future in separate issues. |
A better playground / toggle system for EUI live documentation. Right now we have flat, read-only code displayed next to static examples. It would be nice if people could change the code examples in-browser on our docs site and see the changes live in the examples.
Outcome
An edit mechanism that would allow users to change, add, or otherwise modify props and content in rendered examples.
Related Discussion
Discuss comment; Please note that the ideas mentioned are not requirements but concept suggestions that would need to be thoroughly vetted.
Discuss comment; "having the interactive playground inline in our documentation is something we'd really like to see"
Interested in working on EUI for Google Summer of Code? See more details here: https://github.com/elastic/gsoc
The text was updated successfully, but these errors were encountered: