Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Playground] EuiStep #3866

Merged
merged 4 commits into from
Aug 12, 2020
Merged

[Playground] EuiStep #3866

merged 4 commits into from
Aug 12, 2020

Conversation

anishagg17
Copy link
Contributor

Summary

Makes progress on #3057

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cchaos
Copy link
Contributor

cchaos commented Aug 5, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3866/

cchaos
cchaos suggested changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value selected for status is incorrect.

Screen Shot 2020-08-06 at 11 06 58 AM

The default is actually nothing, so the select box needs something similar to how we've handled a non-selection.

@anishagg17 anishagg17 requested a review from cchaos August 6, 2020 15:26
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3866/

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3866/

@thompsongl thompsongl merged commit 8859362 into elastic:master Aug 12, 2020
@anishagg17 anishagg17 deleted the play_step branch August 12, 2020 15:23
nyurik pushed a commit that referenced this pull request Aug 18, 2020
@anishagg17 @nyurik
[Playground] EuiStep (#3866)
e91e601 
* [Playground] EuiStep

* made propsToUse.status optional

* Update playground.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

@cchaos cchaos Awaiting requested review from cchaos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anishagg17 @kibanamachine @cchaos @thompsongl