Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playground] EuiExpression #3917

Merged
merged 4 commits into from
Aug 18, 2020
Merged

[Playground] EuiExpression #3917

merged 4 commits into from
Aug 18, 2020

Conversation

anishagg17
Copy link
Contributor

Summary

Makes progress on #3057

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3917/

@anishagg17
Copy link
Contributor Author

The new docgen plugin doesn't render props for EuiExpression that's why such issues are arising... Should we close this pr and move forward towards other components until we have a fix for EuiExpression props?

@chandlerprall
Copy link
Contributor

chandlerprall commented Aug 17, 2020

@anishagg17 fix for EuiExpression props has been merged #3929

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3917/

@thompsongl thompsongl merged commit 0bf5673 into elastic:master Aug 18, 2020
@anishagg17 anishagg17 deleted the play_expr branch August 18, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants