Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] added react-live to documentation #2958

Closed
wants to merge 4 commits into from

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Mar 2, 2020

Summary

added react-live to documentation Issue: #3057

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@anishagg17 anishagg17 changed the title [WIP} added react-live to documentation [WIP] added react-live to documentation Mar 2, 2020
@elizabetdev
Copy link
Contributor

jenkins test this

@anishagg17
Copy link
Contributor Author

@chandlerprall their are some problems with react-live library .

The code that we display in DemoJs needs modification if it is to be used in playground but these modifications cause errors in other components .
Should there be separate code for each component and passed as snippet code is passed as this would ensure that it doesn't affect other components..

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2958/

@chandlerprall
Copy link
Contributor

The code that we display in DemoJs needs modification if it is to be used in playground but these modifications cause errors in other components .

This depends on what the playground functionality looks like. Before jumping into any code for this one, it is important to go through the entire application process (https://github.com/elastic/gsoc#application-instructions).

@anishagg17
Copy link
Contributor Author

@chandlerprall I have read this application already ,

@chandlerprall
Copy link
Contributor

Specifically, the application process for these larger Google Summer of Code projects does not start until March 16th and the application itself must be made through the https://summerofcode.withgoogle.com website. After that date, you're able to submit a draft proposal which we can iterate on with you, and the final proposal (in PDF form) is due on March 31st.

You're certainly able to start exploring, but we will not be able to even review proposals until the 16th.

@anishagg17
Copy link
Contributor Author

@chandlerprall I just wanted to know if we could make code for live editor as used by snippets?

@chandlerprall
Copy link
Contributor

Ah, gotcha! Normally this is something we'd be happy to explore. However, because this overlaps with the upcoming playground project I think it'd be best to hold off on this change. I can imagine there's some design work we'd want to do on something like this, and in the end the combined engineering&design effort may be deleted as a result of the playground.

@thompsongl
Copy link
Contributor

Hey @anishagg17 , the issues labelled GSoC are reserved for after the GSoC application process. You already have other EUI PRs to point to for your application, so I'll close this one.

@thompsongl thompsongl closed this Mar 18, 2020
@anishagg17
Copy link
Contributor Author

@thompsongl so how would we describe our work ??

Actually I had implemented it for more than 50 demos locally but hadn't pushed it because of GSoC as I was to mention this pr in my proposal (demonstrating my idea)

@xeraa
Copy link

xeraa commented Mar 18, 2020

https://github.com/elastic/gsoc#application-instructions has the instructions. The PR is not for the project you want to work on but any other bug (or feature, but start small and add more if you can), to show that you can work with the codebase and us 😅

@xeraa
Copy link

xeraa commented Mar 18, 2020

Please read the full description of point 6. in https://github.com/elastic/gsoc#application-instructions, especially

Here is a starting point for issues you could dive into: EUI good first issue

@anishagg17
Copy link
Contributor Author

Okay thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants