Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playground] EuiBottomBar #3870

Closed
wants to merge 1 commit into from

Conversation

anishagg17
Copy link
Contributor

Summary

Makes progress on #3057

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cchaos
Copy link
Contributor

cchaos commented Aug 6, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3870/

@cchaos
Copy link
Contributor

cchaos commented Aug 6, 2020

This one is a bit awkward of a component because it lives in a fixed position portal. Also, it's a component that we will be deprecating soon in favor of EuiControlBar. Let's actually not add a playground to this component for those reasons.

@anishagg17
Copy link
Contributor Author

anishagg17 commented Aug 6, 2020

So should i close this pr??. You may feel free to close any of mine pr .

@cchaos
Copy link
Contributor

cchaos commented Aug 6, 2020

Ok, I'll close this one. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants